The U/V lines of 4:2:0 chroma are divided by 2. But if the height is an odd
number we end up missing the last line for these planes.

Fixes #20290

Fixes #20288

Zhao Zhili authored 7 years ago and Thomas Guillem committed 7 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Zhao Zhili authored 7 years ago and Thomas Guillem committed 7 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

This also fixes the stereo-mode being forgotten when the decoder thread reload
its decoder module and aout.

If the requested stereo-mode is not available, fallback to the default one, but
keep this mode for next inputs. That is why the requested_stereo_mode
intermediate variable is needed.

Mathieu Velten authored 7 years ago and Hugo Beauzée-Luyssen committed 7 years ago

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Fixes #20285

Justin Kim authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

A given URL shouldn't be changed while paying.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Romain Vimont authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

Starting a video may resize the window (if autoresize is enabled). If
the video is started fullscreen, however, the window is not resized, so
its size is unexpected once fullscreen is disabled.

The initial fullscreen mode should not prevent autoresize, so resize the
window when disabling fullscreen.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Romain Vimont authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

restoreStackOldWidget() should always restore the size the widget have
when fullscreen is disabled.

Therefore, save the size before switching to fullscreen, and never
update while fullscreen is enabled.

Fixes #20224

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This also fixes hiding of stats tab in case the respective config
option is unset. Previous code raised error logs here.

See 6b0284b7f41fbb911e5bf160c2d5ddd28b43e6e2. This time with adapted
autolayout constraints.

This reverts the xib to the state before f0534b7a.
Unfortunately, this commit removed all autolayout constraints.

The "apply at next startup" box did not have a localization at all.
The tab views localication was not applied correctly to due to the
panels redesign.

ruciser authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

The implementation of vnc_encrypt_bytes called by vnc_connect needs to add a
return value check on function gcry_cipher_open.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(fixes #20291)

PulseAudio never took it into account.
ALSA needs something else and no longer uses it
(OSS presumably likewise).

Also use the old description. The new one is misleading in the context
of OSSv4 (or ALSA)4 (or ALSA)4 (or ALSA)4 (or ALSA).

(This is untested.)

No functional changes.

We're using KDE Neon Qt5 & friends that fix the UI look and feel for
desktop environments Canonical does not care about, but unfortunately
those packages are not compatible with appmenu-qt5 package from Xenial,
required by desktop-qt5.  The fix here is to replicate the desktop-qt5
snap build proccess, dropping appmenu-qt5 dependency.

Salah-Eddin Shaban authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This reverts commit 2de830a5.
Fix #20026

Ref #19878

Zhao Zhili authored 7 years ago and Thomas Guillem committed 7 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

There were 2 errors that canceled each others:

 - The proper size for UV textures (GL_RG or GL_LUMINANCE_ALPHA) is w/2 x
   h/2 (and not w/2 x h/4).

 - Fix row length with GL_UNPACK_ROW_LENGTH or via an intermediate buffer.
   Don't use the pixel_pitch but the visible_pitch/texture_width ratio. Indeed,
   the pixel pitch for the UV plan of a semi-planar picture is 1 when the ratio
   is 2.

not only if the texture area is empty

Fixes #20215