Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Commit 47a00338 added the wrapper
function, but did not call it.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Each cuInit is leaking memory, and cuInit is supposed to be called only
once. Ensure it through a vlc_once_t wrapper, but since the function
table needs to be loaded in order to call into cuda functions, forward
some available device for the initialization.

Below, there is two leaks because of the double decoder device
allocation in debug mode. The first leak is leaked once, and is still
there. The second and third leaks are now reduced to a single one.

Direct leak of 65536 byte(s) in 1 object(s) allocated from:
    #0 0x7febb6bf3652 in __interceptor_realloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:164
    #1 0x7feb8b56828f  (<unknown module>)

Direct leak of 56 byte(s) in 1 object(s) allocated from:
    #0 0x7febb6bf3459 in __interceptor_calloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:154
    #1 0x7feb89dc586a  (/home/alexandre/workspace/videolabs/vlc-meson/build-native/modules/.libs/libskins2_plugin.so+0x2f1086a)
    #2 0x7febb5f195c1 in decoder_device_Open ../../src/input/decoder_helpers.c:174
    #3 0x7febb5e67106 in vlc_module_load ../../src/modules/modules.c:243
    #4 0x7febb5f196e8 in vlc_decoder_device_Create ../../src/input/decoder_helpers.c:188
    #5 0x7febb60a7435 in vout_GetDevice ../../src/video_output/video_output.c:2244
    #6 0x7febb5ef7f26 in ModuleThread_GetDecoderDevice ../../src/input/decoder.c:608
    #7 0x7feba02ee139 in decoder_GetDecoderDevice ../../include/vlc_codec.h:304
    #8 0x7feba02fb51e in lavc_UpdateVideoFormat ../../modules/codec/avcodec/video.c:286
    #9 0x7feba0313ff7 in ffmpeg_GetFormat ../../modules/codec/avcodec/video.c:1682
    #10 0x7feb9f0bfe12  (/usr/lib/libavcodec.so.58+0x29ae12)

Direct leak of 56 byte(s) in 1 object(s) allocated from:
    #0 0x7febb6bf3459 in __interceptor_calloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:154
    #1 0x7feb8b5d386a  (<unknown module>)
    #2 0x7febb5f195c1 in decoder_device_Open ../../src/input/decoder_helpers.c:174
    #3 0x7febb5e67106 in vlc_module_load ../../src/modules/modules.c:243
    #4 0x7febb5f196e8 in vlc_decoder_device_Create ../../src/input/decoder_helpers.c:188
    #5 0x7febb60a7435 in vout_GetDevice ../../src/video_output/video_output.c:2244
    #6 0x7febb5ef7f26 in ModuleThread_GetDecoderDevice ../../src/input/decoder.c:608
    #7 0x7feba02ee139 in decoder_GetDecoderDevice ../../include/vlc_codec.h:304
    #8 0x7feba02fb51e in lavc_UpdateVideoFormat ../../modules/codec/avcodec/video.c:286
    #9 0x7feba0313ff7 in ffmpeg_GetFormat ../../modules/codec/avcodec/video.c:1682
    #10 0x7feb9f0bfe12  (/usr/lib/libavcodec.so.58+0x29ae12)

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

If --pl-upscaler or --pl-downscaler (the same options as in the
libplacebo vout) are passed, run the pl_scale filter in the OpenGL vout.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Apply an upscaler or downscaler available through libplacebo.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

When a filter changes its output size as a result of
request_output_size(), notify the next filter via a callback.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Resizing the window resulted in a call to a function on the specific
"renderer" filter.

Instead, add a filter callback to handle output resizing, and propagate
the requested input size backwards.

This will allow to properly handle resizing if an upscaler is inserted
before the renderer.

Co-authored-by: Maxime Meissonnier <mmeisson@outlook.fr>

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Expose a function to recreate framebuffers and textures on output size
change.

Co-authored-by: Maxime Meissonnier <mmeisson@outlook.fr>

Maxime Meissonnier authored 5 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It is sometimes useful to iterate backwards.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This prepares to expose output size changes to filters in a generic way.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Only the tex_count assignment differs depending on the filter_planes
flag. The remaining code can be common to both branches.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Move the initialization out of the loop.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Recover the hw pool size from the first Get() call (after the
AVCodecContext has been initialized) and use a semaphore to pace the
picture allocation from Get().

That way, we don't rely anymore av_hwframe_get_buffer() return values,
that returned the same error for internal error or when the pool was
full.

Fixes #26166

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

After pressing `i` to open the info box, pressing `i` again will lead to
the none box, which will display nothing. Instead, store the previous
box when switching to a different box, and restore it instead of
switching to none.

With #26283, autodetection is no longer necessary. All types can be
registered up-front. This also allows switching from one PT to another
without restarting the input.

No functional changes.

This creates an ES only for the packet type (and underlying payload
format) currently used by an RTP source. Consequently, if the session
has more than one packet type, there are no more ghost ES that disrupt
track selection.

Fixes #26283.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

T.Label can't be assigned to a Label

fixes: #26272

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

InterfaceWindowHandler isn't receiving mouse events from the QWindow on X11, now
that we have CSDMouseStealer.qml which properly defines the resize areas, moving
the handling of resize areas from C++ to QML solves this issue and avoids having
the behavior handled in two places.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

CSD where active by default, even when the feature wasn't available

fix: #26293

Advait Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

    
    Fixes #26276
    
    The CSDTitlebarTapnDragHandler snippet was using the onTapped signal without any set delay between the clicks which was causing the windows to maximize even when the second click was long after the first one. Fixed this issue by replacing that signal with onDoubleTapped in which the signal is emitted only when the parent item is tapped twice between a short span of time.
    The window is now maximizing/minimizing only on proper double taps as tested on my local computer.