disabled by default

and remove the assert on the locked state

using stdout by default

Ewout ter Hoeven authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

assert(!ObjectHasChild(obj)) was causing the following data_race:

WARNING: ThreadSanitizer: data race (pid=18491)
  Write of size 8 at 0x7b7000041888 by thread T7 (mutexes: write M150, write M148, write M18):
    #0 vlc_list_add_between ../../include/vlc_list.h:75 (libvlccore.so.9+0xe4765)
    #1 vlc_list_add_before ../../include/vlc_list.h:100 (libvlccore.so.9+0xe4765)
    #2 vlc_list_append ../../include/vlc_list.h:112 (libvlccore.so.9+0xe4765)
    #3 vlc_custom_create ../../src/misc/objects.c:247 (libvlccore.so.9+0xe4765)
    #4 CreateDecoder ../../src/input/decoder.c:1765 (libvlccore.so.9+0x69538)
    #5 decoder_New ../../src/input/decoder.c:2014 (libvlccore.so.9+0x69d1d)
    #6 input_DecoderNew ../../src/input/decoder.c:2077 (libvlccore.so.9+0x6a7a4)
    #7 EsOutCreateDecoder ../../src/input/es_out.c:1824 (libvlccore.so.9+0x7025d)
    #8 EsOutSelectEs ../../src/input/es_out.c:1932 (libvlccore.so.9+0x706c2)
    #9 EsOutSelect ../../src/input/es_out.c:2164 (libvlccore.so.9+0x716e6)
    #10 EsOutVaControlLocked ../../src/input/es_out.c:2523 (libvlccore.so.9+0x77d57)
    #11 EsOutControl ../../src/input/es_out.c:3208 (libvlccore.so.9+0x79f3e)
    #12 es_out_vaControl ../../include/vlc_es_out.h:158 (libvlccore.so.9+0x7c1ba)
    #13 es_out_Control ../../include/vlc_es_out.h:167 (libvlccore.so.9+0x7c1ba)
    #14 CmdExecuteControl ../../src/input/es_out_timeshift.c:1556 (libvlccore.so.9+0x7c4a8)
    #15 ControlLocked ../../src/input/es_out_timeshift.c:638 (libvlccore.so.9+0x7df40)
    #16 Control ../../src/input/es_out_timeshift.c:764 (libvlccore.so.9+0x7e35c)
    #17 es_out_vaControl ../../include/vlc_es_out.h:158 (libvlccore.so.9+0x7fd81)
    #18 es_out_Control ../../include/vlc_es_out.h:167 (libvlccore.so.9+0x7fd81)
    #19 es_out_SetMode ../../src/input/es_out.h:97 (libvlccore.so.9+0x82b25)
    #20 InitPrograms ../../src/input/input.c:1304 (libvlccore.so.9+0x82b25)
    #21 Init ../../src/input/input.c:1385 (libvlccore.so.9+0x8887c)
    #22 Run ../../src/input/input.c:532 (libvlccore.so.9+0x89757)

  Previous read of size 8 at 0x7b7000041888 by thread T20:
    #0 vlc_list_it_next ../../include/vlc_list.h:229 (libvlccore.so.9+0xe42b9)
    #1 ObjectHasChild ../../src/misc/objects.c:83 (libvlccore.so.9+0xe42b9)
    #2 vlc_object_release ../../src/misc/objects.c:405 (libvlccore.so.9+0xe4adf)
    #3 vlc_object_delete ../../include/vlc_objects.h:120 (libvlccore.so.9+0x59210)
    #4 InvokeModule ../../src/preparser/fetcher.c:161 (libvlccore.so.9+0x59210)
    #5 SearchArt ../../src/preparser/fetcher.c:188 (libvlccore.so.9+0x5925a)
    #6 SearchByScope ../../src/preparser/fetcher.c:207 (libvlccore.so.9+0x5a029)
    #7 SearchNetwork ../../src/preparser/fetcher.c:309 (libvlccore.so.9+0x5a068)
    #8 FetcherThread ../../src/preparser/fetcher.c:338 (libvlccore.so.9+0x59153)

sagar-kohli authored 6 years ago and Thomas Guillem committed 6 years ago

Fixes #19388

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Rohan Rajpal authored 6 years ago and Tristan Matthews committed 6 years ago

This was done by commenting out define MSTRTIME_MAX_SIZE
in input_slider.hpp

MSTRTIME_MAX_SIZE is already included via the seekstyle.hpp
input_slider.hpp imports seekstyle.hpp and hence has
MSTRTIME_MAX_SIZE

Closes #21952

Fixes #22005.

This reverts commit 11fc7ec9.

This reverts commit e04412a3.

Fixes #22025.

This reverts commit c29fcde3.

vlc_object_release() is incorrect and will leak.

Since it's not used and built since a long time

Martin Finkel authored 6 years ago and Thomas Guillem committed 6 years ago

Those symbols are internal and lack the LIBVLC_API marker.

Use the same drain emulation than mmdevice.h

This fixes draining with directsound output + directsound stream (Windows XP +
Vista).

Fixes #21985

This function is now always called locked (before the thread is created from
new()).

Ugly but temporary.

Victorien Le Couviour--Tuffet authored 6 years ago and Thomas Guillem committed 6 years ago

The vout can't handle live "video-splitter" change for now.
To work-around this issue, this function will set this variable on the
main vout and restart it through the input control.

François Cartegnie authored 6 years ago and Thomas Guillem committed 6 years ago

should be possible as the timestamps are not converted

Co-authored-by: Denis Charmet <typx@videolan.org>
Co-authored-by: Rémi Denis-Courmont <remi@remlab.net>