- Mar 10, 2022
-
-
This is useful when textures come from a different Adapter/GPU or the bogus access with GPU output.
-
Simplify the close callback which only needs to clean the screen_data_t.
-
If the capture took too long we need to adjust which frame the capture belongs to.
-
-
-
Since ARIB subtitles used in South America are also being recognized, they're not limited to Japanese. Remove the "jpn" tag for the moment.
-
-
-
-
-
Do not assume that the DRM format matches the display source.
-
This provides all known mappings between VLC and DRM pixel formats.
-
This is only used during activation.
-
We don't need two ways to force the pixel format, and DRM formats are more specific (include RGB masks) than VLC's, so stick to those.
-
-
-
Rémi Denis-Courmont authored
-
If anyone has a pthread with a different Windows SDK it should work. It will also avoid bogus pthread.h missing reports when mingw-w64 is not detected properly. HAVE_WINPTHREAD is not checked and assumed to be available.
-
this way it mirrors the behaviour with GridViews
-
-
-
-
This fixes the bad option default for this value. The default being `VPX_DL_GOOD_QUALITY`, which is defined as `1000000` not `0` as seemed to be the author's assumption, did not map to the specified range of 0-2 and thus was getting clamped to 2, corresponding to 'best' quality rather than 'good' quality. It was requested in review to map the option values to match the vpx defines rather than simply change the default value to `0`. This necessitates removal of the range.
-
-
-
-
Unspecified order was: add-button, ban-add-button, ban-list, list.
-
One widget missing from ordering.
-
This was placed into the same grid row+column as a spinbox and thus achieved absolutely nothing. Presumably it was intended for the adjacent column, however since it achieves nothing either way let's just drop it.
-
Makes no difference at all to have this.
-
Viewing the ui files in Qt creator revealed excess empty space at the bottom of some, a huge amount in the case of media-library. This ultimately has no impact upon the final result, but I thought I'd fix it for neatness. Note that these numbers were the product of simply dragging the canvas size until it snapped into place.
-
Such that the effect is thus visible in Qt Creator/Designer. The compatibility note is obviously obsolete now, but presumably we still want this style anyway since its read-only.
-
Regression from 46d15dba. It seems that margins applied to a `QStackLayout` are ignored and must instead be applied to the `QStackWidget` directly.
-
I.e. if compiled without skins2, hide the skinning bits.
-
Rather than have a grid covering the entire contents of the look-n-feel groupbox, which creates unnecessary complexity, use a sub-widget to group together and layout the radio controls and the line underneath, letting the parent layout thus just be a simple vertical-box. Using a widget rather than just a sub-layout is necessary if we are to be able to do things like hide the new selection sub-widget when not applicable. The difference is almost identical, the radio controls are just spaced a few pixels further apart. This puts us in a position to hide the selection control and preview image if skinning is not available (the previous layout did not work for this).
-
Identified by a different invocation of ASAN than I'd previously used. wrt. the second fix it seems `clear()` alone does not destroy these items. ``` Direct leak of 64560 byte(s) in 1345 object(s) allocated from: #0 0x7f1f87268f37 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x7f1f71099981 in ExpertPrefsTableModel::ExpertPrefsTableModel(module_t**, unsigned long, QWidget*) ../../modules/gui/qt/dialogs/preferences/expert_model.cpp:260 #2 0x7f1f710a32fa in PrefsDialog::setExpert() ../../modules/gui/qt/dialogs/preferences/preferences.cpp:106 #3 0x7f1f710a8851 in PrefsDialog::PrefsDialog(QWindow*, qt_intf_t*) ../../modules/gui/qt/dialogs/preferences/preferences.cpp:74 #4 0x7f1f70ee43e2 in DialogsProvider::prefsDialog() ../../modules/gui/qt/dialogs/dialogs_provider.cpp:253 #5 0x7f1f714f6f97 in DialogsProvider::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) gui/qt/dialogs/dialogs_provider.moc.cpp:268 #6 0x7f1f714f7c11 in DialogsProvider::qt_metacall(QMetaObject::Call, int, void**) gui/qt/dialogs/dialogs_provider.moc.cpp:388 #7 0x7f1f70568f1c (/lib/x86_64-linux-gnu/libQt5Qml.so.5+0x2c4f1c) ... Direct leak of 1112 byte(s) in 122 object(s) allocated from: #0 0x7f1f872127a7 in __interceptor_strdup ../../../../src/libsanitizer/asan/asan_interceptors.cpp:454 #1 0x7f1f710950f0 in ExpertPrefsTableItem::ExpertPrefsTableItem(module_config_t*, QString const&, QString const&, bool) ../../modules/gui/qt/dialogs/preferences/expert_model.cpp:61 #2 0x7f1f710999ac in ExpertPrefsTableModel::ExpertPrefsTableModel(module_t**, unsigned long, QWidget*) ../../modules/gui/qt/dialogs/preferences/expert_model.cpp:260 #3 0x7f1f710a32fa in PrefsDialog::setExpert() ../../modules/gui/qt/dialogs/preferences/preferences.cpp:106 #4 0x7f1f710a8851 in PrefsDialog::PrefsDialog(QWindow*, qt_intf_t*) ../../modules/gui/qt/dialogs/preferences/preferences.cpp:74 #5 0x7f1f70ee43e2 in DialogsProvider::prefsDialog() ../../modules/gui/qt/dialogs/dialogs_provider.cpp:253 #6 0x7f1f714f6f97 in DialogsProvider::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) gui/qt/dialogs/dialogs_provider.moc.cpp:268 #7 0x7f1f714f7c11 in DialogsProvider::qt_metacall(QMetaObject::Call, int, void**) gui/qt/dialogs/dialogs_provider.moc.cpp:388 #8 0x7f1f70568f1c (/lib/x86_64-linux-gnu/libQt5Qml.so.5+0x2c4f1c) ... Direct leak of 33 byte(s) in 33 object(s) allocated from: #0 0x7f1f872677cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 #1 0x7f1f86eac342 in vlc_alloc ../../include/vlc_common.h:1149 #2 0x7f1f86eac342 in module_config_get ../../src/modules/modules.c:346 #3 0x7f1f710995f5 in ExpertPrefsTableModel::ExpertPrefsTableModel(module_t**, unsigned long, QWidget*) ../../modules/gui/qt/dialogs/preferences/expert_model.cpp:230 #4 0x7f1f710a32fa in PrefsDialog::setExpert() ../../modules/gui/qt/dialogs/preferences/preferences.cpp:106 #5 0x7f1f710a8851 in PrefsDialog::PrefsDialog(QWindow*, qt_intf_t*) ../../modules/gui/qt/dialogs/preferences/preferences.cpp:74 #6 0x7f1f70ee43e2 in DialogsProvider::prefsDialog() ../../modules/gui/qt/dialogs/dialogs_provider.cpp:253 #7 0x7f1f714f6f97 in DialogsProvider::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) gui/qt/dialogs/dialogs_provider.moc.cpp:268 #8 0x7f1f714f7c11 in DialogsProvider::qt_metacall(QMetaObject::Call, int, void**) gui/qt/dialogs/dialogs_provider.moc.cpp:388 #9 0x7f1f70568f1c (/lib/x86_64-linux-gnu/libQt5Qml.so.5+0x2c4f1c) ``` -
-
-
-
The groupbox had a name that misleadingly suggested that it only contained "instance" related controls when actually it contains both instance and playlist controls. If dbus is not available it is only the instance ones that should be hidden not the entire groupbox.
-
