Alexandre Janniaux authored 3 months ago and Steve Lhomme committed 1 month ago

If the display is opened on a window that is not matching with a
DirectComposition backend or HWND backend, the module should not even
try to open.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

The decoder fifo level metric allows interpreting the situation that led
to the fifo from the decoder to be flushed (ie. the fifo reached 400MiB
of undecoded data stored). The metrics generates a lot of points though,
so be sure to aggregate when displaying it.

Example of query in flux language:

    from(bucket: v.defaultBucket)
    |> range(start: v.timeRangeStart, stop:v.timeRangeStop)
    |> filter(fn: (r) =>
      r._measurement == "measurement" and
      r._field == "fifo_size"
    )
    |> aggregateWindow(every: 1s, fn: max)

The size metrics are casted into uint64_t, but are always below the
uint64_t max value anyway given they represent lesser values than
400MiB.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

Unsigned support allows tracing sizes and counters.

Now that we can position subpictures outside of the video.

If subtitles in black bar is disabled, it's equivalent to the video area.

SPUs using substext can change it if they need to be in the video.

This does the same as using the window dimensions when SPU in black
bars was forced by the core.

...rather than in the video.
It's off by default for now.

This effectively disables "subtitles in black bars" as no SPU source is
setting this flag yet.

"subtitle in black bars" is not opt-in per SPU codec, and per region
for each codec. It is off by default.

Each subpicture needs to decide for itself if it's using the whole display area.

We can't tell before the region is created/updated if it's going to be in video coordinates
or display coordinates.

The core doesn't need to know anymore if a picture is a "subtitle"
(contains timestamps) in "absolute" (video or screen?) coordinates.
It just needs to provide both dimensions.

Since we keep the alignment as well.

They are always "absolute", no need to set it on internal regions.

This is how the IOCallback abstraction works [^1].
Either you read the amount requested, or you return 0.

vlc_stream_Read() reads the whole amount of data, unless it reaches the end of file.
In that case it returns the amount it could read.

[^1]: https://github.com/Matroska-Org/libebml/blob/ba5707e3268be330516c678c7de14af734f0f3b9/ebml/IOCallback.h#L30

Since a878e9d6.

Also remove duplicate include of <climits>.

Alexandre Janniaux authored 1 year ago and Felix Paul Kühne committed 1 month ago

This commit signal the mostlyclean and other dependant targets that it
should clean the targets generated by cargo.

We use a separate target name and add the dependency to
mostlyclean-local so that we can still extend the known automake target.

We also don't use CLEANFILES so that dependencies files are also removed
when using `make mostlyclean-local-rust` to avoid a corrupted tree where
the dependencies would not be removed but the target files they
reference would not exist anymore.

Alexandre Janniaux authored 1 year ago and Felix Paul Kühne committed 1 month ago

It's easier to setup CLEANFILES to $(NULL) at the top makefile and then
always append to it whenever needed.

Steve Lhomme authored 1 month ago and Felix Paul Kühne committed 1 month ago

Either when the video is in portrait mode or when the subtitles
are shown in the black bars and the video area is in portrait mode,
the text can become very large just because we apply a percentage base on
the output height.

We switch mode when the height becomes bigger than the width
so there's a continuity in the ratio when growing/shrinking the
video in one direction or the other.

The static libraries are used in multiple modules for the android
codebase.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

Naming the thread entrypoint vlc_entry is confusing in some of the
stacktraces. In particular, for some reason, Qt's module entrypoint
refers to vlc_entry_license+xxxx (where xxxx is an offset) and it feels
like it's being called from the plugin's entrypoint.


        Thread 14 received signal SIGSEGV, Segmentation fault.
        [Switching to Thread 27108.0x6bf8]
        0x00007ffd41ff499f in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        (gdb) bt
        #0  0x00007ffd41ff499f in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #1  0x00007ffd41ff3d71 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #2  0x00007ffd410d57c5 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #3  0x00007ffd41f7458f in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #4  0x00007ffd4181a9b3 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #5  0x00007ffd414f00a8 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #6  0x00007ffd41a86513 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #7  0x00007ffd41bbf651 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #8  0x00007ffd4193bd97 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #9  0x00007ffd41bbf628 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #10 0x00007ffd410075fa in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #11 0x00007ffd414f3b0e in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #12 0x00007ffd408f65e0 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #13 0x00007ffd631f9dae in vlc_entry (p=0x266f8216810) at /home/janniaux/vlc/extras/package/win32/../../../src/win32/thread.c:354
        #14 0x00007ffdf728e634 in msvcrt!_beginthreadex () from C:\WINDOWS\System32\msvcrt.dll
        #15 0x00007ffdf728e70c in msvcrt!_endthreadex () from C:\WINDOWS\System32\msvcrt.dll
        #16 0x00007ffdf773259d in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\System32\kernel32.dll
        #17 0x00007ffdf906af38 in ntdll!RtlUserThreadStart () from C:\WINDOWS\SYSTEM32\ntdll.dll
        #18 0x0000000000000000 in ?? ()
        Backtrace stopped: previous frame inner to this frame (corrupt stack?)

Khalid Masum authored 1 month ago and Steve Lhomme committed 1 month ago

Backport a patch from Ninja 1.12 that adds python 3.13
support. This is necessary because current version of Ninja
does not work with python 3.13 as pipes module is deprecated.

No need for a ternary operator.

Co-authored-by: Alexandre Janniaux <ajanni@videolabs.io>

Fatih Uzunoğlu authored 1 month ago and Steve Lhomme committed 1 month ago

I do not set `scaledSize` to requested size by default, just to partially
override it when either `width` or `height` is 0. However, this means that we need
to initialize the uninitialized part manually by setting it to non-zero
requested size counterpart as I proposed here.

It is not essential to handle inputs and is not used in this header.