Aleksey Kuznetsov authored 4 years ago and Pierre Lamot committed 4 years ago

"Continue watching" section with list of videos the user started playing
added at the top of the "Video" section.
Scrolling the "Video" page is performed on all area vertically.
Scrolling the "Continue watching" section is horizontal.
In order to preserve loading items on scrolling the content the Continue watching
video section inserted at the top as header of grid view and of list view.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Aleksey Kuznetsov authored 4 years ago and Pierre Lamot committed 4 years ago

Header size in the view were fixed on creating the view and this value
were used for calculating the items positions. If the header changes its
size the view did not take this into account.
Handling the header item size changing added with forcing the layout
updating.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

The count property might be accessed before browsing the model.

Romain Vimont authored 4 years ago and Pierre Lamot committed 4 years ago

MLVideo instances are created from a QThreadPool thread. As a
consequence, as a QObject, each one live (by default) in this separate
thread.

The behavior of dynamic properties or signals/slots would be confusing,
so do not inherit QObject.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Romain Vimont authored 4 years ago and Pierre Lamot committed 4 years ago

VideoDescription and AudioDescription were QObject.

To pave the way to remove the QObject inheritance from MLVideo, convert
them to Q_GADGET and return them by value.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Romain Vimont authored 4 years ago and Pierre Lamot committed 4 years ago

List model items are never cloned.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Romain Vimont authored 4 years ago and Pierre Lamot committed 4 years ago

In list models, items properties are accessed via
QAbstractItemModel::data().

QObjects themselves are not exposed (and must not be exposed) directly,
so the properties are useless.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

It allows to configure the example with, for instance, the following
command line:

    PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/ qmake ..

PKG_CONFIG_PATH can be adapted to the path where libvlc has been
installed and/or where Qt is available.

This also remove the unused parts, and add QT += widgets which is needed
to compile.

Robert-André Mauchin authored 4 years ago and Alexandre Janniaux committed 4 years ago

Compilation would fail with:

> error: 'numeric_limits' is not a member of 'std'

without this include because of some hardening build
flags mandated on Fedora Linux, with GCC 11.

Fix #25325

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Robert-André Mauchin authored 4 years ago and Alexandre Janniaux committed 4 years ago

Compilation would fail with:

> error: 'numeric_limits' is not a member of 'std'

without this include because of some hardening build
flags mandated on Fedora Linux, with GCC 11.

Refs #25325

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Robert-André Mauchin authored 4 years ago and Alexandre Janniaux committed 4 years ago

Compilation would fail with:

> error: 'numeric_limits' is not a member of 'std'

without this include because of some hardening build
flags mandated on Fedora Linux, with GCC 11.

Refs #25325

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

objres are used by nvdec when opening the decoder device so clean them
on failure to avoid a leak.

Indirect leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x7f04fac97f41 in operator new(unsigned long) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x7f04e0928773 in VLCMenuBar::PopupMenu(intf_thread_t*, bool) ../../modules/gui/qt/menus/menus.cpp:864
    #2 0x7f04e060c348 in DialogsProvider::sendKey(int) ../../modules/gui/qt/dialogs/dialogs_provider.cpp:814
    #3 0x7f04de8cc4be in QObject::event(QEvent*) (/usr/lib/libQt5Core.so.5+0x2e24be)
    #4 0x7f04df367751 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib/libQt5Widgets.so.5+0x15a751)

The code is used to detect whether we can allocated the texture, and is
especially designed to handle Apple hardware which should supposedly
support 16bit textures but actually fails during the TexImage2D
allocation call on most Apple OpenGL/ES implementations.

Because it was stacking OpenGL errors, the GL_ASSERT_NOERROR macro would
trigger when enabled, though it should have been silenced into interop
failure instead.

Drain the errors from the OpenGL error stack and return a failure. For
sanity purpose, also assert that there were no errors before this
function so that debug build don't silently drain errors from the
outside.

_enabled is set asynchronously in the main thread whereas
detachFromParent is called from the thread closing the window, which is
usually different from the main thread. Checking _enabled here is racy
and could lead to triggering the assertion.

And not when it is created.

Calling vout functions that need to Hold the vout_control will deadlock
if the vout is not yet started.

If the pool allocation fails or if the vout fails to start (via
input_resource_RequestVout()), an error is returned from
decoder_UpdateVideoFormat(). The next call to
decoder_UpdateVideoFormat() will return a success because the vctx will
be the same since only this variable is checked to detect a vout change.

To fix this issue, clean the owner->fmt and release the vctx when
returning an error.

The condition variable was shared across all variables of a given
object to save space, but it ends up waking up the wrong waiting
threads.

vlc_cond_t is not as large as it used to be. In fact, it could be as
small as a single pointer: if we required holding the mutex during
signal/broadcast. The nested mutex is only there to handle unprotected
signalling.

The content is always owned by the called, and since the
ArtCacheCreateDir doesn't change the string content, we can simply use
the string passed in parameter without any need for a copy

The folder is always owned by the caller, so we can modify it directly
and save a copy per folder level

It's not in any other file

With the currently used version neither native nor cross-compilation appears to be supported.