Reimplementation depends on media libary exposing a feature comparable to bookmarks, which is scheduled in time for the 4.0 release

not the complete and efficient way.
we'll need a better inheritance fix at parsing level.

Test leftovers.

Regression from e1c82853

This was inadvertently removed during rebase/merge.

Fixes #22188

This reverts commit 496001e6.

The objects don't leak anymore.

This reverts commit 1a350d8d.

This should fix historical aliasing issues.

Allocate the object private data separately - stop relying on alignment
and unconventional pointer arithmetic. This adds (internal) functions
to (de)initialize an object in place.

This effectively reverts commit 07998682.

Sean McGovern authored 5 years ago and Rémi Denis-Courmont committed 5 years ago

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

(again)

In file included from ../../include/vlc_common.h:1190,
                 from ../../src/input/decoder_helpers.c:29:
../../src/input/decoder_helpers.c: In function ‘vlc_decoder_device_Create’:
../../include/vlc_modules.h:70:47: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
             vlc_module_load(vlc_object_logger((vlc_object_t *)(ctx)), cap, \
../../include/vlc_objects.h:64:15: note: in definition of macro ‘VLC_OBJECT’
     _Generic((x)->obj, \
               ^
../../include/vlc_modules.h:70:29: note: in expansion of macro ‘vlc_object_logger’
             vlc_module_load(vlc_object_logger((vlc_object_t *)(ctx)), cap, \
                             ^~~~~~~~~~~~~~~~~
../../src/input/decoder_helpers.c:135:20: note: in expansion of macro ‘vlc_module_load’
     priv->module = vlc_module_load(&priv->device, "decoder device", name,
                    ^~~~~~~~~~~~~~~

char * can alias anything, and Winsock relies on that. Unfortunately,
the compiler still issues warnings. This works around that.

Fix support for 32-bits platforms.
Regression from 46ea30cd.

This is not guaranteed.

Originally, POSIX made it unsigned. This was relaxed in newer releases,
but unsigned makes more sense anyway since it expressses a size.