UPnP crashing in the release

See #8474 (closed), #7093 (closed), #9974 (closed), #10013 (closed) #10316 (closed)

added Severity::normal Type::bug Version::master git + 1 deleted label

changed milestone to %Bugs paradize

assigned to @Courmisch and unassigned @MigrationBot

added Component::Services discovery label and removed 1 deleted label

changed title from Upnp Crashing in the release to UPnP crashing in the release

Patch welcome

unassigned @Courmisch

changed the description

Confirming problem persists in 2.1.3 for Windows (Windows 7 professional x64)

I can also confirm the issue exists in version 2.1.3 on Windows 8.1 Pro, 64 bit.

Occurs on Win 8.1 in http://nightlies.videolan.org/build/win32/vlc-2.2.0-20140307-0031/vlc-2.2.0-git-20140307-0031-win32.exe too

Original author: adam baxter

qt4 debug: Sorting by column -1, order 0 main debug: adding services_discovery upnp{longname="Universal Plug'n'Play"}... main debug: looking for services_discovery module matching "upnp": 8 candidates upnp info: Initializing libupnp on* '(null)*' interface upnp error: Initialization failed: UPNP_E_SOCKET_ERROR main debug: no services_discovery modules matched main error: no suitable services discovery module

Doesn't libupnp find the right interface? So it binds to 'null' which generates the UPNP_E_SOCKET_ERROR

@Wlancable From the documentation it seems that opening inteface '(null)' should be OK - it should just open the first available interface: http://libupnp4.sourcearchive.com/documentation/1.8.0~svn20090313-1/group__UPnPAPI_gfaa05cc70555bbbd47073a978b719dc1.html

Looking at modules/services_discovery/upnp.cpp around lines 100-120 I see that the message "upnp info: Initializing libupnp on ... interface" is only logged when UPNP_ENABLE_IPV6 is defined. This uses the UpnpInit2() routine from the library instead of UpnpInit() which is used if UPNP_ENABLE_IPV6 is undefined.

Looking at the log of a working version of VLC (2.0.3) there is no "upnp info: Initializing libupnp on ... interface" which suggests that UPNP_ENABLE_IPV6 is undefined.

I wonder if there is a problem on Windows with the behaviour in the case where UPNP_ENABLE_IPV6 is defined. In which case a quick fix might be to undefine UPNP_ENABLE_IPV6 on windows.

At the moment I am not sure I have the energy to set-up a build environment to test this. Perhaps someone with this already set-up could try it.

My first try with DLNA. Windows 7 Pro SP1 x64 VLC 2.1.5 freezes when clicking on up'n'p. Google led me to this site. 2.0.8 does work. DLNA Server is VU+ Ultimo VTi 8.0.0, WMP working.

I confirm that this problem persists from version 2.0.8 to 2.2.0pre3 with the OS:

Windows Vista - 32 Bit Windows 7 - 32 Bit Windows 8 - 64 Bit Windows 8.1 - 64 Bit

Same here, Windows 7 starter - 32bit. Last working version 2.0.8. On linux versions it just doesn't show upnp network devices.

Try 3.0.0

added Status::fixed label

changed milestone to %3.0.0

closed