Commits on Source (30)
-
https://github.com/taglib/taglib/pull/662 (cherry picked from commit 84962e47) (rebased)
109d2ac2 -
Since the only part that matters to taglib is the filename, and more specifically the extension part. (cherry picked from commit 026a7606)
db09e821 -
Steve Lhomme authored
(cherry picked from commit 4bc7607f) (edited) edited: - keep the support for taglib older than 1.11 which doesn't have the proper FileRef constructor to use it - the aacresolver is only called for Taglib 1.11+ on 3.0 - 4.0 doesn't make a difference for UWP or regular Windows
df406faf -
We can't do it through vlc_stream_NewURL as it will include the skiptags filter (cherry picked from commit 976cd219)
c2ca6c30 -
Warnings were happening because we were using copy operator= as the assigned object was already initialized. This patch use the copy constructor or move constructor instead if available. Those warnings were: ../../modules/meta_engine/taglib.cpp: In function ‘void ReadMetaFromXiph(TagLib::Ogg::XiphComment*, demux_meta_t*, vlc_meta_t*)’: ../../modules/meta_engine/taglib.cpp:672:39: warning: implicitly-declared ‘TagLib::StringList& TagLib::StringList::operator=(const TagLib::StringList&)’ is deprecated [-Wdeprecated-copy] 672 | list = tag->fieldListMap()[keyName]; \ | ^ ../../modules/meta_engine/taglib.cpp:681:5: note: in expansion of macro ‘SET’ 681 | SET( "COPYRIGHT", Copyright ); | ^~~ In file included from /usr/include/taglib/fileref.h:30, from ../../modules/meta_engine/taglib.cpp:58: /usr/include/taglib/tstringlist.h:59:5: note: because ‘TagLib::StringList’ has user-provided ‘TagLib::StringList::StringList(const TagLib::StringList&)’ 59 | StringList(const StringList &l); | ^~~~~~~~~~ Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org> (cherry picked from commit be4f907a)
3720cf2c -
(cherry picked from commit 3257bb4a) (rebased) rebased: - 3.0 already switched to 1.12 with less patches
630b2f68 -
(cherry picked from commit 0cbcf504)
3a4b557a -
(cherry picked from commit 837b583e) (rebased) rebased: - 3.0 already has 1.11 ifdef
00cbfcce -
(cherry picked from commit d375284a) (rebased) rebased: - 3.0 already has 1.11 ifdef
625675cd -
taglib reads unlimited if no IDv3 or MPEG header is found at the beginning. (cherry picked from commit 8ec8b0d2) (rebased) rebased: - only used with Taglib 1.11+ which is not always the case with 3.0
88e4dc19 -
Steve Lhomme authored
list is already a different local list defined earlier in the function. (cherry picked from commit 34ca2a28)
e60dd2df -
The convertion will incur a cost which we don't want to pay since the art needs to be encoded in base64, which doesn't include anything outside of ASCII (cherry picked from commit 65dfe0cd)
fc401e9b -
(cherry picked from commit d2663d6c)
7c09325e -
contains() was added in 1.10 and item() is supported since 1.9 (cherry picked from commit ac59d0ba)
72446e87 -
This is already done implicitly (cherry picked from commit 93842f65)
7b2f1d35 -
upstreamed at: https://github.com/taglib/taglib/pull/1040 Fix #26602 (cherry picked from commit 2f82d6b9)
d226e0c6 -
(cherry picked from commit 89e20ea0)
ba858385 -
(cherry picked from commit 53260ca5)
01c9003d -
(cherry picked from commit 584fd17a)
286d843d -
Steve Lhomme authored
We can just use auto and always get the proper type. (cherry picked from commit 74131267)
651da62c -
This is the version that was merged upstream so it makes sense to use it to facilitate future rebases upstream PR: https://github.com/taglib/taglib/pull/1040 (cherry picked from commit c5893a22)
97f309a7 -
(cherry picked from commit 436526ec) (rebased)
78af081d -
It is no longer needed with contribs taglib updated to 1.13. (cherry picked from commit c5851fd4)
6da0cba6 -
Steve Lhomme authored
Changelog: https://github.com/taglib/taglib/releases/tag/v1.13.1 (cherry picked from commit c7cceca6)
e69ef263 -
`WriteMetaToId3v2` expects a `ID3v2::Tag` instead of `Tag`, but Since TagLib v2.0, `RIFF::WAV::File::tag()` returns a `Tag` instead of `ID3v2::Tag`, hence replace the usage of `tag()` method with `ID3v2Tag()`. https://github.com/taglib/taglib/blob/master/taglib/riff/wav/wavfile.h#L124 Additionally, to resolve the compilation error, the function signatures of `insert` and `removeBlock` have been adjusted to align with the base class functions. (cherry picked from commit ec29dfca)
5ee481af
Showing
- contrib/src/taglib/0001-Implement-ID3v2-readStyle-avoid-worst-case.patch 148 additions, 0 deletions...lib/0001-Implement-ID3v2-readStyle-avoid-worst-case.patch
- contrib/src/taglib/SHA512SUMS 1 addition, 1 deletioncontrib/src/taglib/SHA512SUMS
- contrib/src/taglib/rules.mak 2 additions, 1 deletioncontrib/src/taglib/rules.mak
- modules/meta_engine/taglib.cpp 301 additions, 173 deletionsmodules/meta_engine/taglib.cpp