Skip to content
Snippets Groups Projects
Commit 65dfe0cd authored by Hugo Beauzée-Luyssen's avatar Hugo Beauzée-Luyssen
Browse files

taglib: Don't convert base64 strings to UTF8

The convertion will incur a cost which we don't want to pay since the
art needs to be encoded in base64, which doesn't include anything
outside of ASCII
parent 0f2a579a
No related branches found
No related tags found
1 merge request!612taglib: Don't convert base64 strings to UTF8
Pipeline #138078 passed with stages
in 28 minutes and 55 seconds
......@@ -764,7 +764,7 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t* p_demux_meta,
const char* psz_description = "cover";
uint8_t *p_data;
int i_data = vlc_b64_decode_binary( &p_data, art_list[0].toCString(true) );
int i_data = vlc_b64_decode_binary( &p_data, art_list[0].toCString(false) );
msg_Dbg( p_demux_meta, "Found embedded art: %s (%s) is %i bytes",
psz_name, psz_mime, i_data );
......@@ -782,7 +782,7 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t* p_demux_meta,
uint8_t *p_data;
int i_cover_score;
int i_cover_idx;
int i_data = vlc_b64_decode_binary( &p_data, block_picture_list[0].toCString(true) );
int i_data = vlc_b64_decode_binary( &p_data, block_picture_list[0].toCString(false) );
i_cover_score = i_cover_idx = 0;
/* TODO: Use i_cover_score / i_cover_idx to select the picture. */
p_attachment = ParseFlacPicture( p_data, i_data, 0,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment