Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The macro parameter name was the same as the member name ("sampler"). To
avoid the problem, use a static inline function instead.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The macro parameter name was the same as the member name ("filter"). To
avoid the problem, use a static inline function instead.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

For consistency, always pass the sampler to callbacks as a non-const
pointer.

vlc_gl_filter_GetSampler() may fail (return NULL), but the caller need
not explicitly cleanup the returned sampler on success.

Therefore, retrieve the sampler as soon as possible to simplify error
handling.

On first call, vlc_gl_filter_GetSampler() may return NULL, so check the
return value.

It doesn't work in UWP as that part of the registry is not available via
CoCreateInstanceFromApp(). This might be available via DeviceInformation
from winrt Windows.Devices.Enumeration (not available in wine yet) in the
Properties dictionary, but it would be for UAP/UWP builds only.

Cannot be ported back to 3.0 as this is Vista and above.

This is often used in pair with OLE API's like SysAllocString or VariantInit.

This is necessary in UAP/Winstore builds as it's not part of the default libs.

Marvin Scholz authored 3 years ago and Thomas Guillem committed 3 years ago

Fixup user-provided URIs, similar to what most browser nowadays do.

Fix #21661

Nicolas LeQuec authored 3 years ago and Thomas Guillem committed 3 years ago

Use of the previouly created trace API to collect data from demuxer, decoder and video_output.
Fields "type", "id", and "stream" are then used by a script to identify data and name curves to
display.
Here is the link of the script project: https://gitlab.com/videolabs/public/vlc-pa

Nicolas LeQuec authored 3 years ago and Thomas Guillem committed 3 years ago

In traces, it's useful to have the str_id of the elementary stream read.
It can be obtained through the clock.

Nicolas LeQuec authored 3 years ago and Thomas Guillem committed 3 years ago

In traces, it's useful to have the id of the decoder used.

Nicolas LeQuec authored 3 years ago and Thomas Guillem committed 3 years ago

Add a trace module that stores the traces in a file or displays them
in stdout with a json notation.

Nicolas LeQuec authored 3 years ago and Thomas Guillem committed 3 years ago

Tracing system is independant from the logging system and load modules with a "tracer" capability.
The tracer module is loaded at the initialisation of a libvlc instance.

Marvin Scholz authored 3 years ago and Romain Vimont committed 3 years ago

Fixes #21661

Marvin Scholz authored 3 years ago and Romain Vimont committed 3 years ago

Fixes #21661

Samuel Bassaly authored 3 years ago and David committed 3 years ago

Add stereo pan filter to Advanced Audio Effects panel.

Add enable button for each filter, as pan audio effect has effect over
the whole spectrum (always noticeable), thus, if always enabled, it
makes pitch adjustment unusable.

Additionally, for pitch adjustment:
- Update the step of the scale to 0.25
- Fix the default value to 0.0 (was previously 0.25)

Closes issue #25872

Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The previous implementation made us lose the keyboard focus each time we set 'localMenuDelegate' to null.

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The header internal.h is really a header for interop_sw.c.

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

It is only used from interop.c.

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

This will allow to reference opengl_interop_init_impl without forward
declaration.

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

  typo in previous refactor

  fix: #25997

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The matrix to bind might be different for each plane.

This avoids to expose the exact same module in different plugins.

Moreover, the "draw" filter is necessary to the OpenGL filter engine,
but is not directly related to any vout, so it was odd to include it in
vout plugins.

The header filter.h was included twice.

Gather all libgl_plugin.la declarations at the same place.