also skips some memcpy

refs #27454 #27477

(cherry picked from commit c14b5aa6)

(cherry picked from commit ded62a06) (edited)
edited:
* some of the 3.0 code was different

(cherry picked from commit 1f179973) (edited)
edited:
* some of the 3.0 code was different

Keep a copy of vlc_tick_tfor backward compatibility.

(cherry picked from commit ff56c92a) (edited)
edited:
* some of the 3.0 code is different

Rémi Denis-Courmont authored 3 years ago and Steve Lhomme committed 2 years ago

This unbreaks packages using autoreconf.

(cherry picked from commit 7beb0605)

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Marvin Scholz authored 2 years ago and David committed 2 years ago

Adding nil to an NSArray would make it raise an
NSInvalidArgumentException which in turn leads to an abort in
dispatch_once:
  https://github.com/apple-oss-distributions/libdispatch/blob/55c3a68e9ec47f1c1d5bb9909404ce5f0351edef/src/object.m#L557



Fix #27487

(cherry picked from commit 41ec80a1)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Marvin Scholz authored 2 years ago and Felix Paul Kühne committed 2 years ago

When VLC was launched from a file, the handling for playlist
change events was not sufficient as in case of starting with
a file, we could miss the event and never report CanPlay.

When playing a file from a service discovery, like our Lua
web parser scripts, this logic was flawed too, as the playlist
would always be "empty" even though we are clearly currently
paused on an input. To fix that, check if CanPlay disagrees
with reality when we get an input change and emit CanPlay.

There is no check added in the item append/delete sections,
so currently once an item from an SD is played, even when
the user has switched back to the main playlist, the status
would still be CanPlay until and item is added or removed
in the "main" playlist. However this exactly matches how the
Qt interface behaves, so I've left this behavior as-is for
consistency with the interface.

Fix #21419
Fix #22785

Marvin Scholz authored 2 years ago and Felix Paul Kühne committed 2 years ago

The can-seek and can-pause variables could end up
not being set, as the callback events are not reliably
fired in case the variables changed before the callbacks
are attached.
Additionally we need to report the playback status properly
whenever a new item starts playing.

Fix #24699

David authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

CFNetwork library is automatically added by recent SDKs. By replacing
this framework with CoreServices.framework, we retain support for Mac OSX 10.7.

David authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

CFNetwork library is automatically added by recent SDKs. By replacing
this framework with CoreServices.framework, we retain support for Mac OS
X 10.7.

Pierre Ynard authored 2 years ago and Steve Lhomme committed 2 years ago

Fixes #27529

(cherry picked from commit a0b3c438)

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Zhao Zhili authored 6 years ago and Steve Lhomme committed 2 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
(cherry picked from commit c53aefcc)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Alexandre Janniaux authored 4 years ago and Marvin Scholz committed 2 years ago

(cherry picked from commit 7eb922bc)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Alexandre Janniaux authored 4 years ago and Marvin Scholz committed 2 years ago

With autoconf 2.70, the following warnings are emitted:

configure.ac:56: warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete
./lib/autoconf/programs.m4:716: _AC_PROG_LEX is expanded from...
./lib/autoconf/programs.m4:709: AC_PROG_LEX is expanded from...
configure.ac:56: the top level

The documentation[1] of autoconf now states:

> Prior to Autoconf 2.70, AC_PROG_LEX did not take any arguments, and
> its behavior was different from either of the above possibilities: it
> would search for a library that defines yywrap, and would set LEXLIB
> to that library if it finds one. However, if a library that defines
> this function could not be found, LEXLIB would be left empty and LEX
> would not be reset. This behavior was due to a bug, but several
> packages came to depend on it, so AC_PROG_LEX still does this if
> neither the yywrap nor the noyywrap option is given.
>
> Usage of AC_PROG_LEX without choosing one of the yywrap or noyywrap
> options is deprecated. It is usually better to use noyywrap and define
> the yywrap function yourself, as this almost always renders the LEXLIB
> unnecessary.

The behaviour of the argument on autoconf < 2.70 is to ignore the
argument, so there are no issues with adding the option.

[1] https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/html_node/Particular-Programs.html#Particular-Programs



(cherry picked from commit 824b3d45)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

That way, we will always use MapInputLayout() on tvOS/iOS.

(cherry picked from commit ebc27c6e)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

(cherry picked from commit cac29a17)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

Simpler, tested on tvOS 14 and 16. On tvOS, the device can adapt to the
VLC input format, in contrary to macOS.

Fixes 7.1 surround.

(cherry picked from commit 3d92b1c3)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

There is one more complete just after.

(cherry picked from commit 704d6fcf)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

(cherry picked from commit 28e4d7fe)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

(cherry picked from commit c65da638)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

Could not test it.

(cherry picked from commit 082a0305)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

Tested on macOS 12.5, compared with the same vlc/sample/amplifier on
Windows.

Surround and RearSurround are indeed swapped for 7.1, same for tvOS (cf.
next).

But why ?

(cherry picked from commit 0a65098f)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

The current size of the array is 35 for 9 elements.

The maximum value for AudioChannelLabel is 65536 and we want to avoid
having an array of 65536 for very few elements.

(cherry picked from commit 9d676d26)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

And not both.

On macOS, VLC need to adapt its fmt to the output layout (it can't
change it).
on tvOS, VLC can send its custom input layout.

Fixes #27474
Also fix 7.1 mapping on macOS (Center was on Left...).

(cherry picked from commit 87bbf8f2)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

(cherry picked from commit 0405833c)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

(cherry picked from commit 12683ccc)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

Regression from 91f42699

This fixes the shortcut to map channels to Center or Stereo.

(cherry picked from commit b73f7c40)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Alexandre Janniaux authored 6 years ago and Steve Lhomme committed 2 years ago

... at the end of the loop.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
(cherry picked from commit 603ade4f)

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

partial bp of 10318107

Lyndon Brown authored 6 years ago and Steve Lhomme committed 2 years ago

the `NeAACDecSetConfiguration()` function copies attributes from the given
config object to the actual config held within the decoder context object.
it validates each config attribute before copying it, immediately returning
zero if the attribute is invalid.

we should use the return value to check that our config was successfully
written.

(cherry picked from commit 8beee731)

François Cartegnie authored 5 years ago and Steve Lhomme committed 2 years ago

(cherry picked from commit c8d7729a)

François Cartegnie authored 6 years ago and Steve Lhomme committed 2 years ago

(cherry picked from commit eaedf156)

(cherry picked from commit 0f9cde94)

(cherry picked from commit aeca11e9)

(cherry picked from commit 9d83a7ee)

(cherry picked from commit c5b37cb4)

(cherry picked from commit a54d02b0)

(cherry picked from commit 7d37ad40)

(cherry picked from commit f9b0cad3)