Skip to content
Snippets Groups Projects
  1. Dec 02, 2022
  2. Nov 30, 2022
  3. Nov 27, 2022
    • Marvin Scholz's avatar
      macosx: fix possible SPMediaKeyTap crash · b64b9c22
      Marvin Scholz authored and David's avatar David committed
      Adding nil to an NSArray would make it raise an
      NSInvalidArgumentException which in turn leads to an abort in
      dispatch_once:
        https://github.com/apple-oss-distributions/libdispatch/blob/55c3a68e9ec47f1c1d5bb9909404ce5f0351edef/src/object.m#L557
      
      
      
      Fix #27487
      
      (cherry picked from commit 41ec80a1)
      Signed-off-by: default avatarMarvin Scholz <epirat07@gmail.com>
      b64b9c22
    • Marvin Scholz's avatar
      control: dbus: emit CanPlay consistently · 8bf90465
      Marvin Scholz authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      When VLC was launched from a file, the handling for playlist
      change events was not sufficient as in case of starting with
      a file, we could miss the event and never report CanPlay.
      
      When playing a file from a service discovery, like our Lua
      web parser scripts, this logic was flawed too, as the playlist
      would always be "empty" even though we are clearly currently
      paused on an input. To fix that, check if CanPlay disagrees
      with reality when we get an input change and emit CanPlay.
      
      There is no check added in the item append/delete sections,
      so currently once an item from an SD is played, even when
      the user has switched back to the main playlist, the status
      would still be CanPlay until and item is added or removed
      in the "main" playlist. However this exactly matches how the
      Qt interface behaves, so I've left this behavior as-is for
      consistency with the interface.
      
      Fix #21419
      Fix #22785
      8bf90465
    • Marvin Scholz's avatar
      control: dbus: emit events properly on input change · 1c037bc6
      Marvin Scholz authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      The can-seek and can-pause variables could end up
      not being set, as the callback events are not reliably
      fired in case the variables changed before the callbacks
      are attached.
      Additionally we need to report the playback status properly
      whenever a new item starts playing.
      
      Fix #24699
      1c037bc6
  4. Nov 26, 2022
  5. Nov 19, 2022
  6. Nov 17, 2022
  7. Nov 15, 2022
    • Alexandre Janniaux's avatar
      configure.ac: fix deprecated mention with newer autoconf · 0a33447a
      Alexandre Janniaux authored and Marvin Scholz's avatar Marvin Scholz committed
      
      (cherry picked from commit 7eb922bc)
      Signed-off-by: default avatarMarvin Scholz <epirat07@gmail.com>
      0a33447a
    • Alexandre Janniaux's avatar
      configure.ac: fix AC_PROG_LEX warning · cacf92f3
      Alexandre Janniaux authored and Marvin Scholz's avatar Marvin Scholz committed
      With autoconf 2.70, the following warnings are emitted:
      
      configure.ac:56: warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete
      ./lib/autoconf/programs.m4:716: _AC_PROG_LEX is expanded from...
      ./lib/autoconf/programs.m4:709: AC_PROG_LEX is expanded from...
      configure.ac:56: the top level
      
      The documentation[1] of autoconf now states:
      
      > Prior to Autoconf 2.70, AC_PROG_LEX did not take any arguments, and
      > its behavior was different from either of the above possibilities: it
      > would search for a library that defines yywrap, and would set LEXLIB
      > to that library if it finds one. However, if a library that defines
      > this function could not be found, LEXLIB would be left empty and LEX
      > would not be reset. This behavior was due to a bug, but several
      > packages came to depend on it, so AC_PROG_LEX still does this if
      > neither the yywrap nor the noyywrap option is given.
      >
      > Usage of AC_PROG_LEX without choosing one of the yywrap or noyywrap
      > options is deprecated. It is usually better to use noyywrap and define
      > the yywrap function yourself, as this almost always renders the LEXLIB
      > unnecessary.
      
      The behaviour of the argument on autoconf < 2.70 is to ignore the
      argument, so there are no issues with adding the option.
      
      [1] https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/html_node/Particular-Programs.html#Particular-Programs
      
      
      
      (cherry picked from commit 824b3d45)
      Signed-off-by: default avatarMarvin Scholz <epirat07@gmail.com>
      cacf92f3
  8. Nov 08, 2022
  9. Nov 05, 2022
  10. Nov 04, 2022
Loading