Co-authored-by: Alexandre Janniaux <ajanni@videolabs.io>

Fatih Uzunoğlu authored 1 month ago and Steve Lhomme committed 1 month ago

I do not set `scaledSize` to requested size by default, just to partially
override it when either `width` or `height` is 0. However, this means that we need
to initialize the uninitialized part manually by setting it to non-zero
requested size counterpart as I proposed here.

It is not essential to handle inputs and is not used in this header.

Gabriel Lafond-Thenaille authored 4 months ago and Steve Lhomme committed 1 month ago

 * Replace `vlc_preparser_GenerateThumbnail` and `vlc_picture_Export`
   by `vlc_preparser_GenerateThumbnailToFiles`.

Gabriel Lafond-Thenaille authored 2 months ago and Steve Lhomme committed 1 month ago

 * Fix a crash due to variable on a stack not available when a callback
   try to use it.

Brad Smith authored 1 month ago and Steve Lhomme committed 1 month ago

- thread id
- thread naming
- CPU feature detection

When the protoc version is in the a.b.c format the protobuf version
is in the a.b.c.d format. Some version of pkg-config allow the equality
of the two, but not all.

We can just make sure protobuf is between a.b.c and a.b.(c+1).

Fixes #29066

Fixes #28995

A "gathered" SPU is assembled to send to the decoder, and the decoder then handles
the data from there. But it was never released.

Fixes #28992

The p_new element was never added to the chain.

Fixes #28990

arm-unknown-linux-androideabi is not the correct triplet for android.

vlc_module_name should not be exposed in static cfg for now, since it's
not partially linked into each plugin and thus conflicts with the
libvlc/vlccore's definition.

Just as with autotools it may not test the actual compat version of a function,
but the one provided by the toolchain. That allows validating the tests
with the real thing.

The regions can only use "absolute" coordinates since there is no updater.

There will be no region in the SPU and it will never be updated. We don't
need a SPU at all.

Alexandre Janniaux authored 1 month ago and Felix Paul Kühne committed 1 month ago

The test was added in autoconf buildsystem in the following commit:
967e3744.

Pierre Lamot authored 1 month ago and Felix Paul Kühne committed 1 month ago

fix #29034

Steve Lhomme authored 1 month ago and Felix Paul Kühne committed 1 month ago

It's only needed to render the subpicture. The updater should have priority,
as is done in the "last minute" rendering.

Alexandre Janniaux authored 1 month ago and Felix Paul Kühne committed 1 month ago

-Bsymbolic flag is needed when compiling the module with static ffmpeg
build.

Alexandre Janniaux authored 1 month ago and Felix Paul Kühne committed 1 month ago

aarch64-unknown-linux-android is not the correct triplet for compiling
rust for android, and "-unknown" should be dropped.

The same applies to other targets except armv7, which ends with
androideabi instead of android.

Prince Gupta authored 1 month ago and Steve Lhomme committed 1 month ago

useful for changes following this commit

Prince Gupta authored 1 month ago and Steve Lhomme committed 1 month ago

Have a common class in all menu wrappers that implement
some basic functionality - visibility and memory management

implement tableView_popup function for Network context menu

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

On the C side, the category is read as an int type:

```c
        /* src/modules/entry.c */
        case VLC_CONFIG_CREATE:
        {
            int type = va_arg (ap, int);
```

On the Rust side, it is then incorrect to inject an i64:

```rust
        vlc_set(
                opaque,
                ::std::ptr::null_mut(),
                ::vlcrs_core::plugin::ModuleProperties::CONFIG_CREATE as _,
                // incorrect
                ::vlcrs_core::plugin::ConfigModule::SUBCATEGORY as i64,
                &mut config as *mut *mut ::vlcrs_core::plugin::vlc_param,
        )
```

It fixes such ABI error, and in particular a crash on android armv7.

Most of the time the loop exits on the first round.

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Sometimes the primary detail string on a media library media item and
the duration string, so don't add the duration string onto the smaller
text field if this is the case

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

macosx: Universally adopt 10px bottom padding for internal contents of media library item supplementary detail view

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>