lib: play/add_intf/exit_handler cleanup

Supersedes !4852 (closed)

Doing a new MR as this is a major change.

cf. discussion here !4852 (comment 424558)

WARNING: This MR remove the ability to spawn a specific interface from LibVLC

(it is ok for me, but is it for everyone?)

changed milestone to %4.0

added Component::Bindings: LibVLC (native API) label

added MRStatus::Reviewable label

WARNING: This MR remove the ability to spawn a specific interface from LibVLC

The alternative being adding a bool start parameter to libvlc_add_intf but it's still considered a bad practice to load modules by name.

That said I don't know if it's actually used by our libvlc users so I don't have strong feelings either way.

it's still considered a bad practice to load modules by name.

Side note: the argument makes sense for pipeline modules, but interfaces that are not things like dbus are probably better loaded explicitely.

AFAICT, only WinVLC still loads one interface explicitly. It can be left out of the scope of this MR, but that sounds like a WinVLC bug TBH.

added MRStatus::Acceptable label and removed MRStatus::Reviewable label

winvlc calls "globalhotkeys" directly, it's not the case for the xcb one because it adds an "autorun" feature. This does not sound like something that should be added when using libvlc (rather than VLC). IMO it's that "autorun" thing that seems wrong.

On the other hand the "autorun" is only used when calling libvlc_add_intf() with NULL (default interface). So it should be OK to add the hotkeys with our default interface.

mentioned in merge request !4866 (merged)

For libvlc it's still possible to pass the interface via the libvlc_new() parameters. It's not something you would turn on and off during runtime.

added MRStatus::InReview label and removed MRStatus::Acceptable label

resolved all threads

added MRStatus::Acceptable label and removed MRStatus::InReview label

I agree that it would be wrong to trigger autorun in LibVLC. But that's not happening. That's why autorun is only triggered whilst adding an interface.

And I think autorun is less ugly than hard-coding which interface to start automatically in the executable.

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, and score >= 0
• MergeRequest should have no activity (threads/votes) for (24h/24h)

This message was automatically generated by homer-bot.

added 16 commits

• c3a757c0...051c1c06 - 8 commits from branch videolan:master
• bcc966dd - lib: document internal play/intf/exit functions
• 706d874f - bin: use libvlc_Internal API directly
• bab4561a - test: use libvlc_Internal API directly
• a43c0662 - lib: remove libvlc_playlist_play
• a58c260b - lib: remove libvlc_add_intf
• e68569eb - lib: remove empty playlist.c
• 5e513f16 - lib: remove libvlc_set_exit_handler
• ea2a1a71 - lib: remove deprecated.h

Compare with previous version

enabled an automatic merge when the pipeline for ea2a1a71 succeeds

mentioned in merge request !4852 (closed)

There's a build error with meson:

cc -o bin/vlc-static bin/vlc-static.p/vlc.c.o bin/vlc-static.p/override.c.o --coverage -Wl,--as-needed -Wl,--no-undefined '-Wl,-rpath,ORIGIN/../lib:ORIGIN/../src' -Wl,-rpath-link,/builds/tguillem/vlc/build-meson/lib -Wl,-rpath-link,/builds/tguillem/vlc/build-meson/src -Wl,--start-group lib/libvlc.so -lm -ldl -Wl,--end-group -pthread /usr/bin/ld: bin/vlc-static.p/vlc.c.o: undefined reference to symbol 'libvlc_InternalPlay' /usr/bin/ld: /builds/tguillem/vlc/build-meson/src/libvlccore.so.9: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status