lib: undeprecate libvlc_playlist_play()

On top of !4851 (merged), review only the 3 last commits here.

libvlc_playlist_play is used in the following code:

bin/darwinvlc.m
bin/winvlc.c
bin/vlc.c
test/src/misc/image_cvpx.c
test/src/input/decoder/input_decoder.c
test/src/misc/image.c
test/src/video_output/video_output.c
test/iosvlc.m
test/modules/stream_out/transcode.c
test/modules/misc/medialibrary.c
test/modules/lua/extension.c

And we have no plan for any alternatives.

changed milestone to %4.0

added Component::Bindings: LibVLC (native API) label

Depends on !4851 (merged)

changed the description

added MRStatus::Reviewable label

Typo in "cf. next commit for a better function documention."

added 3 commits

• dea7484c - lib: undeprecate libvlc_playlist_play
• 0c5567d4 - lib: document libvlc_playlist_play()
• 9888af31 - lib: remove deprecated.h

Compare with previous version

changed the description

added MRStatus::InReview label and removed MRStatus::Reviewable label

added 2 commits

• 671080f6 - lib: document libvlc_playlist_play()
• 41e5a007 - lib: remove deprecated.h

Compare with previous version

I don't think that there's no credible possibility to remove it. It's just that nobody cared.

The point here was that LibVLC should not use it. I'm not stuck up on the deprecation warning, but I do want a warning. We've seen enough devs mistakenly using the function as it stands.

I added a warning

I meant a compiler warning.

Then, we can't build the vlc binary or tests without that warning.

And what about the build without warning badge ?

The bins and tests could easily (and probably should) call directly libvlc_InternalPlay

Naup, it is not possible as libvlc_instance_t is private.

Many tests already include libvlc_internal.h and interact with p_libvlc_int and so do some <platorm>/specifics.c so bins could include it as well. It doesn't shock me to have our internals to use internal stuff.

If the goal is to prevent libvlc users to call libvlc_playlist_play() I'd rather remove it from the libvlc public interface.

I think we could probably just start playback from add_intf or from the interfaces, but I am fine with deleting the function entirely as @typx suggests.

OK, fine with me.

But then, we need to remove/hide add_intf ? Is it not useless alone ? (and it can't interact with the libvlc_media_player)

Well then since it seems that every libvlc_add_intf() is immediately followed by libvlc_playlist_play we could, indeed as @Courmisch suggests it, call libvlc_InternalPlay directly from libvlc_add_intf

Hmm with the exception of winvlc.c...

added 2 commits

• 64467462 - lib: document libvlc_playlist_play()
• fdae46e5 - lib: remove deprecated.h

Compare with previous version

added MRStatus::NotCompliant label and removed MRStatus::InReview label

mentioned in merge request !4865 (merged)

Superseded by !4865 (merged)

closed