Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 3.0.x protected
  • 3.0.21-1 protected
  • 3.0.21 protected
  • 3.0.20 protected
  • 3.0.19 protected
  • 3.0.18 protected
  • 3.0.18-rc2 protected
  • 3.0.18-rc protected
  • 3.0.17.4 protected
  • 3.0.17.3 protected
  • 3.0.17.2 protected
  • 3.0.17-1 protected
  • 3.0.17 protected
  • 3.0.16 protected
  • 3.0.15 protected
  • 3.0.14 protected
  • 3.0.13 protected
  • 3.0.12.1 protected
  • 3.0.12-1 protected
  • 3.0.12 protected
  • 3.0.11.1 protected
22 results
Search by author
  • Any Author
  • Administrator Administrator root
  • Alaric Senat Alaric Senat asenat
  • Alexandre Janniaux Alexandre Janniaux alexandre-janniaux
  • Bart - The Review Bot Bart - The Review Bot Bart
  • Benjamin Arnaud Benjamin Arnaud bunjee
  • Christophe Massiot Christophe Massiot cmassiot
  • Claudio Cambra Claudio Cambra claucambra
  • David David dfuhrmann
  • Denis Charmet Denis Charmet typx
  • Fatih Uzunoğlu Fatih Uzunoğlu fuzun
  • Felix Paul Kühne Felix Paul Kühne fkuehne
  • François Cartegnie François Cartegnie fcartegnie
  • Gabriel Lafond-Thenaille Gabriel Lafond-Thenaille gabriel_lt
  • **** **** project_435_bot
  • **** **** project_435_bot_867220ea9cbb40f38051abad33491375
  • Ilkka Ollakka Ilkka Ollakka ileoo
  • Jean-Baptiste Kempf Jean-Baptiste Kempf jbk
  • Jean-Paul Saman Jean-Paul Saman jpsaman
  • Johannes Kauffmann Johannes Kauffmann JohannesKauffmann
  • Konstantin Pavlov Konstantin Pavlov thresh
20 authors
  1. Feb 17, 2016
    • Hugo Beauzée-Luyssen's avatar
      qt4: playlist: Fix leak · f2684ca0
      Hugo Beauzée-Luyssen authored
      f2684ca0
    • Hugo Beauzée-Luyssen's avatar
      upnp: Fetch the server icon · 0cff5611
      Hugo Beauzée-Luyssen authored
      0cff5611
    • Filip Roséen's avatar
      nothrow new in cases where it maches intent · 1bed74fe
      Filip Roséen authored and Hugo Beauzée-Luyssen's avatar Hugo Beauzée-Luyssen committed 
      
I wrote a hackish script to locate instances where new can throw
but where the original author has assumed that it will return
nullptr when there is a memory allocation problem.

In short, cases such as `ptr = new T; if (ptr) ...` has now
been changed to `ptr = new (std::nothrow) T; if (ptr) ...`.

Since a throwing `new` will always yield a non-nullptr pointer,
code that follows similar patterns to the previous example are
therefor redundant.

Example (from modules/access/dshow/filter.cpp):

    *ppEnum = new CaptureEnumMediaTypes( p_input, p_pin, this );

    if( *ppEnum == NULL )
      return E_OUTOFMEMORY; // unreachable, new will never return NULL

Fixed:

    *ppEnum = new (std::nothrow) CaptureEnumMediaTypes( p_input, p_pin, this );

    if( *ppEnum == NULL )
      return E_OUTOFMEMORY;

Signed-off-by: default avatarHugo Beauzée-Luyssen <hugo@beauzee.fr>
      1bed74fe
  3. Feb 16, 2016
  5. Feb 15, 2016
  7. Feb 14, 2016
  9. Feb 13, 2016
  11. Feb 12, 2016

VideoLAN code repository instance