libass plugin links to libiconv unconditionally

In some cases, libc may provide the iconv*() functions.

According to the GNU automake documentation, this should be fixable by only adding libiconv to the link dependancies when the AC_SEARCH_LIBS macro sets ac_cv_search_ to 'none required'.

See https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Libraries.html#Libraries

Why is it better?

Replying to [comment:1 jb]:

Why is it better?

It's not so much a case of 'better' as it is that linking the plugin can fail when libiconv is not present (and not required in the case that it is covered in libc). ;)

The good new is that I have a patch for this, and will attach it momentarily.

libass: fix pkg-config file when libiconv is not present

Added attachment:

• 0001-contrib-libass-fix-pkg-config-file-when-libiconv-is-.patch

added Status::fixed label

changed milestone to %3.0 FF

closed

Milestone renamed