Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

When inheriting from classes with a virtual destructor, it is not needed
to declare the destructor both as virtual and override. In line with the
normal policy for virtual vs override, use virtual only when declaring
the base class destructor.

Regression from a89c7662 that is still usable
in UWP.

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

bogus seek after chained content
regression by 7b091b21

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

We can't assume page are small.
and seeks to wrong/outside of stream pos if
stream does not start time 0

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

returning negative error on these

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Audio latency callback is using the fifo lock, which cannot be released
until the audio output is destroyed. In general, outputs can use the
fifo, and we need to release/detach them from the input decoder before
freeing the lock.

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

1111 becomes 1111000064 due to imprecision

PathIsNetworkPathW() is a basic function that only checks for \\ and
[a-zA-Z]:\\ pathes [1]. It's also not available on UWP apps.

We can do the same by checking the UTF-8 string directly without even a
conversion to wide char string.

[1] https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-pathisnetworkpathw

The 4x 12 bits packing is making the bitfield packing messy and incompatible
with (non)MS packing in dvdnav. In the end the structures are not read as
packed structures so we don't need to keep them packed.

Upstream patch proposed at videolan/libdvdread!42

Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

Now that Q_DECL_OVERRIDE is gone, update HACKING for the usage of
override.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

It's available starting with xdg-toplevel version 5, and we use
xdg-wm-base version 1 or the version adding configure_bounds which is
version 4, so we don't need to set a handler for now.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Fixes a missing initializer warning for axis_value120. We currently
enforce version = 5 for the wl_seat version, and it's available starting
with wl_pointer version 8, which means that we don't need to set a
function handler for now.

Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

When sout_StreamDelete is called from sout_StreamNew, p_stream->psz_name
is set to NULL, so don't pass it to msg_Dbg.

Prince Gupta authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

global drop events are already handled on qml side
no need to handle it twice

ref #27190