Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC
Manage
Activity
Members
Labels
Plan
Issues
4k
Issue boards
Milestones
Code
Merge requests
451
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC
Commits
a749fb90
Commit
a749fb90
authored
2 years ago
by
Benjamin Arnaud
Committed by
Steve Lhomme
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
qml/PlaybackSpeed(s): Fix keyboard navigation
parent
37a55445
No related branches found
Branches containing commit
No related tags found
1 merge request
!2361
qml: Add a dedicated Popup for the Teletext settings
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
modules/gui/qt/player/qml/PlaybackSpeed.qml
+2
-4
2 additions, 4 deletions
modules/gui/qt/player/qml/PlaybackSpeed.qml
modules/gui/qt/player/qml/controlbarcontrols/PlaybackSpeedButton.qml
+17
-0
17 additions, 0 deletions
.../qt/player/qml/controlbarcontrols/PlaybackSpeedButton.qml
with
19 additions
and
4 deletions
modules/gui/qt/player/qml/PlaybackSpeed.qml
+
2
−
4
View file @
a749fb90
...
...
@@ -202,7 +202,7 @@ ColumnLayout {
focus
:
true
Navigation.parentItem
:
row
B
Navigation.parentItem
:
row
A
Navigation.downItem
:
slider
onClicked
:
slider
.
value
=
0
...
...
@@ -333,12 +333,10 @@ ColumnLayout {
bgColor
:
root
.
colors
.
button
borderColor
:
root
.
colors
.
buttonBorder
// NOTE: Applying the right theme to the ComboBox.
Navigation.parentItem
:
rowB
// NOTE: This makes the navigation
convenient
since 'up' is changing the comboBox value.
// NOTE: This makes the navigation
possible
since 'up' is changing the comboBox value.
Navigation.leftItem
:
slider
Navigation.rightItem
:
slider
Component.onCompleted
:
{
for
(
var
i
=
0
;
i
<
_model
.
length
;
i
++
)
{
...
...
This diff is collapsed.
Click to expand it.
modules/gui/qt/player/qml/controlbarcontrols/PlaybackSpeedButton.qml
+
17
−
0
View file @
a749fb90
...
...
@@ -38,6 +38,20 @@ Widgets.IconControlButton {
color
:
(
popup
.
visible
)
?
colors
.
accent
:
colors
.
playerControlBarFg
// FIXME: We can't use upItem because a Popup is not an Item.
Navigation.upAction
:
function
()
{
if
(
popup
.
visible
)
{
popup
.
forceActiveFocus
(
Qt
.
TabFocusReason
)
return
}
var
parent
=
Navigation
.
parentItem
;
if
(
parent
)
parent
.
Navigation
.
defaultNavigationUp
()
}
onClicked
:
popup
.
open
()
Popup
{
...
...
@@ -115,6 +129,9 @@ Widgets.IconControlButton {
colors
:
root
.
colors
Navigation.parentItem
:
root
// NOTE: Mapping the right direction because the down action triggers the ComboBox.
Navigation.rightItem
:
root
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment