Shaleen Jain authored 6 years ago and Hugo Beauzée-Luyssen committed 6 years ago

Move out UpnpInstanceWrapper into its own file
since it no longer has any dependencies on existing
modules and allow other modules to get references to it.
Move as well as the various helper functions that are
directly required by the UpnpInstanceWrapper class
and inline them for a small performance gain.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Shaleen Jain authored 6 years ago and Hugo Beauzée-Luyssen committed 6 years ago

Introduce a Listener interface to
UpnpInstanceWrapper that can be used
by modules to get UpnpEvent callbacks
from libupnp decoupling UpnpInstanceWrapper
from any specific module or its members.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Zhao Zhili authored 6 years ago and Tristan Matthews committed 6 years ago

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

Zhao Zhili authored 6 years ago and Tristan Matthews committed 6 years ago

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

Cherry-picked from 93a3f58b

Cherry-picked from 043cde8a

Cherry-picked from commits:

5bf3ee01
8bb28646

Cherry-picked from 7d69fdb7

This reverts commit e51f96aa.

This fixes a regression introduced in a6e1e1b0

The variable is a hostname / address, not an URL.

Salah-Eddin Shaban authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

Some fonts like Sakkal Majalla have a large max_advance_width, apparently due to some glyphs that are rarely if ever used. This was causing "Invalid max width" errors for text that did fit the available width.

So the calculation of max advance has been modified to take into account only the glyphs we are actually rendering.

Fixes #20102

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Since the times have moved from mtime_t to time_t,
both lastcheck and now have same value over
the two successive calls.
It is then never scheduled, or only on next
condsignal or wall clock scheduled command.

Explicitely allowed by the remaining copyright holder, Boris Dorès,
whose agreement was misunderstood by /me.

Alejandro González authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

According to my
code review and testing, the vlc.httpd() Lua method does not take any
arguments and neither support HTTPS in the current VLC version. Also, the
documentation doesn't make it clear on what type of Lua modules it's
available, when it can only be used in the context of interfaces.

Some code snippets that seem to support the findings mentioned above:
modules/lua/intf.c#L258
modules/lua/libs/httpd.c#L82

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Add a check for the malloc result to prevent passing NULL to
CFStringGetCString.

The old getCStringCopyForCFStringRef function had a flaw that would
cause a heap-buffer overflow if the CFString easy obtaining of the
pointer fails and the string contains characters that need more than
one byte.

To fix this, remove the old getCStringCopyForCFStringRef and use the
recently added CFStringCopyUTF8CString instead, and generalized it to
work with any encoding. Additionally add a check for the malloc
result to prevent passing NULL to CFStringGetCString.

Fix #20721

Not used for now.

It breaks the binary which won't run on W10 (at least)

Modify configure.in before reconfiguring, to avoid requiring the
dependency on gettext.

This will, most likely, destroy DirectDraw rendering in dr

The lua "mdate" remains the same.

The lua "mwait" remains the same.