Subtitle disappears in full-screen mode with specific font

Subtitles works fine in normal-screen mode but fully disappear in full-screen mode. When I exit the full-screen mode the subtitle seems to be shifted towards the top left corner before it goes back to its normal location. https://drive.google.com/file/d/1tx6ZfZdRl12HwI3YOIQxtsp03N6-LF0e/view?usp=sharing

Windows pro 10 x64

Please provide your verbose logs

Seems similar to #20101 (closed)

added Component::Subtitles label

changed milestone to %3.0.x maintenance

freetype error: LayoutParagraph(): Invalid max width

What is the font used? And what size?

It is an Arabic Windows font named "Sakkal Majalla", font size set to smaller! I tried to change it to "Arial", and it worked just fine!

This font "Sakkal Majalla" used to work just fine with the previous versions of VLC. It is one of the default installed Arabic fonts by windows/office.

changed title from Subtitle disappears in full-screen mode! to Subtitle disappears in full-screen mode with specific font

I managed to reproduce this as follows:

With a 1280x528 video, and the font set to Sakkal Majalla, CTRL + Wheel Up to scale the text to 200%. When windowed the text is rendered fine for Subrip and OSD. In full screen (with a resolution of 1920x1080) no text appears and LayoutParagraph(): Invalid max width is reported.

With the higher resolution a larger font size is used and FT_MulFix in LoadGlyphs() causes an overflow. This does not happen with Arial because it has a lower max_advance_width

This seems to fix it:

#!diff
diff --git a/modules/text_renderer/freetype/text_layout.c b/modules/text_renderer/freetype/text_layout.c
index cf80c52..e658025 100644
--- a/modules/text_renderer/freetype/text_layout.c
+++ b/modules/text_renderer/freetype/text_layout.c
@@ -1153,7 +1153,7 @@ static int LoadGlyphs( filter_t *p_filter, paragraph_t *p_paragraph,
             }
         }

-        int i_max_run_advance_x = FT_FLOOR( FT_MulFix( p_face->max_advance_width, p_face->size->metrics.x_scale ) );
+        int i_max_run_advance_x = FT_FLOOR( FT_MulFix( ( long long ) p_face->max_advance_width, p_face->size->metrics.x_scale ) );
         if( i_max_run_advance_x > *pi_max_advance_x )
             *pi_max_advance_x = i_max_run_advance_x;
     }

OK I've submitted a patch.

Even with the overflow fixed, I was still unable to scale the text above 400% with a 1280x720 video using the Sakkal Majalla font. So the patch uses advance values of individual glyphs when setting pi_max_advance_x instead of the font's max_advance_width

Fixed.

added Status::fixed label

changed milestone to %3.0.4

closed

marked #20101 (closed) as a duplicate of this issue

marked this issue as related to #20101 (closed)