Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This is useful when we only want to return a cached item.

Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

fix #25668

Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

fix #25663

Lyndon Brown authored 6 years ago and Hugo Beauzée-Luyssen committed 3 years ago

it confused me in the past when I tried `vlc -p pulse` and it came back
with an error stating that no matching module was found, and to look in
the list generated by --list, when that does in fact contain a module with
that name.

the problem is that the module has no options (nor pulsesrc/pulselist),
and the underlying logic is geared primarily towards --full-help/--longhelp
output which deliberately skips over such modules.

i have finally looked into this and fixed the confusing behaviour by
avoiding skipping over modules when in search mode, so now we output
minimal details about such modules along with a statement that it has no
options when looking up modules, but continue to skip over them in
--full-help/--longhelp output.

old output:
```
lyndon@desktop ~$ vlc -p pulse
VLC media player 4.0.0-dev Otto Chriek (revision 4.0.0-dev-15406-g183c8d9971)

No matching module found. Use --list or --list-verbose to list available modules.
```

new output:
```
lyndon@desktop ~$ vlc -p pulse
VLC media player 4.0.0-dev Otto Chriek (revision 4.0.0-dev-15407-g19c204c671)

 Pulseaudio audio output (pulse)
  This module has no options.

 PulseAudio input (pulsesrc)
 Pass pulse:// to open the default PulseAudio source, or pulse://SOURCE to open a specific source named SOURCE.
  This module has no options.

 Audio capture (PulseAudio) (pulselist)
  This module has no options.
```

Fix #25555

Refs #25555

Martin Finkel authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

libvlc_media_new_callbacks does not set imem-get and imem-release.
Because of this, the following logs
imem Error: Invalid get/release function pointers
are confusing users. This commit aligns behavior with imem-access.c
which also returns VLC_EGENERIC silently for missing read_cb.

Fixes deprecated usage of libvlc_media_parse.

In order to use it from other tests.

The path is valid from the CIs but not from my local machine.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

InputSourceInit() is called to initialize the master and all slaves
inputs. Some initialisation concerned only the master, so move them out to a
new function: InitProperties().

This fixes the input slaves overriding some item properties
(attachment) and the master capabilities.

Martin Finkel authored 4 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Signed-off-by: Martin Finkel <martin@videolabs.io>

Martin Finkel authored 4 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Signed-off-by: Martin Finkel <martin@videolabs.io>

The previous calculation was wrong and could lead to two potential
issues:
 - Too much wake/sleep because the block remaining data is very small
 - Too long sleep, if the block is longer than the buffer size, that
   could lead to underrun

To fix this issue, use the same sleep calculation than wasapi.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This WAYLAND_CFLAGS was probably meant to be WAYLAND_CLIENT_CFLAGS. The
former doesn't exist on my system, the latter is required for
compilation to succeed.

Lyndon Brown authored 5 years ago and Pierre Lamot committed 3 years ago

as per comment, these have no relevance to GUI prefs

Lyndon Brown authored 5 years ago and Pierre Lamot committed 3 years ago

this includes a fix for the following flaw: if for any reason a
set_subcategory() call followed by no options was ever placed at the end
of the core option set, then this would have dereferenced memory beyond
the end of the set. (Note that such empty entries currently genuinely
exist in order to ensure that respective tree nodes are created for
modules to attach to, which will be fixed later).

Lyndon Brown authored 5 years ago and Pierre Lamot committed 3 years ago

saves wasting effort

Lyndon Brown authored 6 years ago and Pierre Lamot committed 3 years ago

(add common defines for specifying hidden category/subcategory)

Fix a regression introduced in
adfe2249
Fix #25605

Increase to 300M to allow to build universal releases.
This is the maximum size of the release image, the final
file will be only at the usual compressed size.

This reverts commit 105de271.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

cf. !68

The clock source selection depends on priv->b_can_pace_control but this
variable is only initialized from the input_thread_t after the demux is
opened. Programs and ES tracks can be created from the demux open
callback or midstream (from the demux callback). Therefore, we can't
handle the clock source selection after the program is created since
priv->b_can_pace_control might not be initialized. To fix this issue,
handle clock source selection when the first PCR is sent (from
ES_OUT_SET_PCR).

No functional changes.

Allow to attach the clock listener after the input clock is created.

No functional changes for now since only one master is created from
es_out.c (for now).

The input master clock has a higher priority than the ES master clock.
There can be one input master and one es master at a given time. In that
case, the ES master will behave as a slave clock.

This will allow to be more flexible from the es_out.c when creating
input and ES clocks.