Either because Reset() set the same input value or the we're using the same
value set by the previous AppendXXX().

Needed for the code cleaning in the next patches.

The last output format is always the format of the last filter. It doesn't
matter if it was allowed to change the format or not. It's either the filter
added or the "chain" filter added to compensate for the format change (should
be adjusted in push mode)

This is how filter_chain_GetFmtOut() is documented "last output format of the
last element in the filter chain" and how it's used.

If there's no filter yet, the output format is the one used to initialize the
filter chain (via filter_chain_Reset).

The filter chain itself doesn't automatically adapt the output format to the
requested output format, which is good for push.

Use the local variable set on the whole chain rather than the value set on each
filter.

Similar to the input video context variable.

This matches the previous iTunes support.

Johan Gunnarsson authored 5 years ago and Thomas Guillem committed 5 years ago

Make sure the dbg macro can't compile down to nothing, so it can be used in
if statements without braces.

codec/telx.c: In function ‘Decode’:
codec/telx.c:686:81: warning: suggest braces around empty body in an ‘if’
statement [-Wempty-body]
(long int)(p_sys->prev_pts+1500000)));
                                     ^

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Shared runners will pick up the builds now

A instance of VLCOpenBlockDeviceDescription was casted to NSDictionary leading to a runtime exception (#23091).

This patch addresses the problem and prevents future issues by setting the class on the arrays.

Zhao Zhili authored 5 years ago and Thomas Guillem committed 5 years ago

Documentation of the API doesn't guarantee any particular error code.

Suggested by Thomas Guillem

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

In order to notify the user if he should wait for the stopped event.

And improve the libvlc_media_player_stop_async documentation.

In order to notify the user if he should wait for the stopped event.

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

In case of error, the registry variable is clobbered by the goto from
error handling and is freed without a correct value.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Sean McGovern authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Zhao Zhili authored 5 years ago and Thomas Guillem committed 5 years ago

strerror_r can be GNU-specific on Android.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Zhao Zhili authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

getmntent_r is not necessarily available when the mntent.h header is present
(cf.  Android).

It's part of vd that is already passed to the module loader.

We keep VLC_VIDEO_CONTEXT_NONE to 0 to make sure some context are not created
accidentally with a type value of 0.

Johan Gunnarsson authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Qt requires container elements to be copyable, https://bugreports.qt.io/browse/QTBUG-54685
but class with const members can't be copy-assignable. Remove the const values
so that we can copy SoutChain.

This patch fix the compilation with Clang 9.

This is needed so that the built contribs are actually packaged.

We try to get the minimum amount that is guaranteed to work. We don't want to
fail in the middle of playback because we actually did not have enough surfaces.

It gives 1 when it should be 8. Other codecs seem to be OK.

We don't use the display pool (vout_GetPicture) anymore.

The frame rate is a field per second. To get a duration we divide seconds by
the number of fields. This what the vlc_tick_from_samples() call does. But we
divide by 0 without this fix.

We don't want to use the hardware decoder for now.

This is similar to what is done in the display module.

This is similar to what is done in the display module.