Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

Needed shortly for the editing dialog of 'expert' prefs mode.

Note that I have not implemented it for `KeySelectorControl` since
I intend to exclude hotkeys entirely from expert mode.

Lyndon Brown authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Rename `fillGrid()` to `insertInto()` and expose publically instead of
pointlessly hiding behind `insertIntoExistingGrid()`.

Lyndon Brown authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Our control classes are not widgets, deriving from `QObject` not `QWidget`.
Their component widgets are inserted into an external parent widget which
effectively passes ownership to that widget - when that widget is destroyed
any widgets it encapsulates will automatically also be destroyed.
Destructors of our control classes should thus not attempt to delete their
component widgets, since unless the control object is destroyed first, the
destructor will get called twice.

The unnecessary explicit deletion of this component widget within this
control class destructor was thus risking such double-destruction. This did
not seem to be occurring within the current codebase, however I happened to
encounter it in some later work.

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

Experiments proved that `fixed` should be the default for this type of
control; it otherwise expands to capture additional height in some layouts.

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Errors are signaled by -1, so the type has to be signed.

There are no needs to force 8-bit sign extension here since the
non-error result is always positive. So better use a fast type.

Regression from 88e3a4f0.
Fixes #26679.

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

If a subtraction underflows, we do not care what the exact result is,
only that it is large.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's better for debugging than "generic".

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Only assume luac is available for native builds. Otherwise we need $(HOST)-luac.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Maybe it was OK to keep it in 3.0 but in 4.0 we can't expect to reuse ancient
folders, just to save a luac rebuild.

Also add a nice message when configuring.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Only assume protoc is available for native builds.

Otherwise we check '$(HOST)-protoc' and 'protoc'.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Most libvlc usage means displaying the video in their own UI with their own
style. We should not push our OSD style by default. It can still be added
back with an "osd" parameter when calling libvlc_new().

Keep the OSD on Desktop builds, although with the Qt integration it may be
better to do it in the UI layer as well.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This will avoid lengthy variable declarations.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Only supported by the D3D11 renderer for now.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

It's only needed from get_address(), from Open().

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

And switch to meson.

François Cartegnie authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

fixes regression with some templates
https://livesim.dashif.org/livesim/testpic_2s/Manifest.mpd