upstreamed at: https://github.com/taglib/taglib/pull/1040
Fix #26602

This is already done implicitly

Fixes CVE-2021-31566, CVE-2021-36976

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Doxygen for libvlc_video_output_cfg_t and libvlc_video_render_cfg_t
were not correct and led to the documentation of one field being
assigned to the field after it.

In the future, the fields might need more precision regarding the
possible ranges or kind of values they can convey, so use a top
comment instead of a sibling one, which can more easily integrate
a brief and a longer explanation.

Prince Gupta authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

fixes horizontal resize handle not changing the cursor shape

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

it seems the code assumed that null m_videoVisual means that video
visual is not in the visual tree but that assumption is wrong, this
caused the addition of acrylic visual to fail just after the video is
played and stopped. In that case the videoVisual will not be null but
also will not be in visual tree

Always insert acrylic visual below all siblings.
probably fixes #26279

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Cache the dsm session when closing. It will be re-used if an other
access is opened on the same server/share/username within 5 seconds.

Small benchmark, time to open the dsm access:
 - 100 - 150 ms without cache
 - 1 ms with a cache

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Cache the smb2 session when closing. It will be re-used if an other
access is opened on the same server/share/username within 5 seconds.

Small benchmark, time to open the smb2 access:
 - 200 - 250ms without cache
 - 20 - 30 ms with a cache

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

No functional changes.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Instead of using the same context from the access_sys struct.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Helper that can be used by any accesses, that will save up to 5 contexts
up to 5 seconds (both configurable with a define).

This helper create its own thread that will release the resources when
unused.

This helper also use the gcc destructor attribute to clean everything
when the library is unloaded.

This helper need a destructor, thus it can only be used with gcc and
clang.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

PointingTooltip.position was removed in commit 5f674bc6

Benjamin Arnaud authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

fix #25732

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

previously when the image is found in the cache, the generator
was not reset, this caused an invalid image to be loaded

reset the image generator on update request

David authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

OpenJDK builds now exist for arm macOS, and both compilation and execution
of java blurays seem to work fine.

Closes #26023

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

No functional changes.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Early fail and leave the function or continue the loop when an error
happens. The code will less look like a tornado and will directly
signal what happens in case of error, without breaking the flow of the
current success path.

Indentation is not changed to ease review, and will be changed in
a subsequent commit.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

They allow easier error handling in the loop, and will provide the
foundation for much more simplification in the end.

Alexandre Janniaux authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

The new contrib fixes a bunch of reported CVE:

    CVE-2021-30498  (tga export, not concerned)
    CVE-2021-30499  (troff export, not concerned)
    CVE-2021-3410   (canvas.c, v0.99.beta19)
    CVE-2018-20546  (dither.c, v0.99.beta19)
    CVE-2018-20547  (dither.c, v0.99.beta19)
    CVE-2018-20545  (load_image, v0.99.beta19)
    CVE-2018-20548  (load_image, v0.99.beta19)
    CVE-2018-20549  (caca_file_read, 0.99.beta19, not concerned)

See release note[^1] on the github project.

It also allow to migrate the use of the new API instead of libcucul,
which has been merged into libcaca since 0.99.beta15:

    commit f61816ceb7445f8bf818936151554ac060764b39
    Author: Sam Hocevar <sam@hocevar.net>
    Date:   Sat Sep 27 13:12:46 2008 +0000

    Starting refactoring to get rid of libcucul. The initial reason for the
    split is rendered moot by the plugin system: when enabled, binaries do
    not link directly with libX11 or libGL. I hope this is a step towards
    more consisteny and clarity.

It was then completely wiped out by the following commit, which is part
of v0.99.beta20:

    commit 5f0ec215f8c9915ed028324a8ecac8212f68e18d
    Author: Sam Hocevar <sam@hocevar.net>
    Date:   Thu May 3 10:33:30 2018 +0200

    Remove legacy code from 10 years ago.

Check NEWS for details:

    \section news0_99_beta15 Changes between 0.99.beta15 and 0.99.beta14

     - libcucul was merged back into libcaca for more clarity

[^1]: https://github.com/cacalabs/libcaca/releases/tag/v0.99.beta20

Alexandre Janniaux authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Migrate to the new API instead of libcucul API, which has been merged
into libcaca since 0.99.beta15:

    commit f61816ceb7445f8bf818936151554ac060764b39
    Author: Sam Hocevar <sam@hocevar.net>
    Date:   Sat Sep 27 13:12:46 2008 +0000

    Starting refactoring to get rid of libcucul. The initial reason for the
    split is rendered moot by the plugin system: when enabled, binaries do
    not link directly with libX11 or libGL. I hope this is a step towards
    more consisteny and clarity.

It was then completely wiped out by the following commit, which is part
of v0.99.beta20:

    commit 5f0ec215f8c9915ed028324a8ecac8212f68e18d
    Author: Sam Hocevar <sam@hocevar.net>
    Date:   Thu May 3 10:33:30 2018 +0200

    Remove legacy code from 10 years ago.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

We no longer build with pthreadGC2 since f1bf4b45