- Apr 09, 2022
-
-
-
-
Reset the meter fmt to NULL when destroying the stream. WARNING: ThreadSanitizer: heap-use-after-free (pid=45968) Read of size 1 at 0x7b4400019fdc by main thread: #0 aout_filter_Create ../../src/audio_output/filters.c:56 (libvlccore.so.9+0xa4945) #1 vlc_audio_meter_CreatePluginFilter ../../src/audio_output/meter.c:83 (libvlccore.so.9+0xa7074) #2 vlc_audio_meter_AddPlugin ../../src/audio_output/meter.c:108 (libvlccore.so.9+0xa71df) #3 aout_AddMeterPlugin ../../src/audio_output/output.c:1008 (libvlccore.so.9+0xaa088) #4 vlc_player_AddMetadataLoudnessListener ../../src/player/metadata.c:106 (libvlccore.so.9+0x98f93) #5 vlc_player_AddMetadataListener ../../src/player/metadata.c:181 (libvlccore.so.9+0x990bc) #6 test_audio_loudness_meter ../../test/src/player/player.c:2842 (test_src_player+0x5db2) #7 main ../../test/src/player/player.c:2961 (test_src_player+0xa9fa) Previous write of size 8 at 0x7b4400019fd8 by main thread: #0 free ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:711 (libtsan.so.0+0x368a8) #1 vlc_player_track_priv_Delete ../../src/player/track.c:145 (libvlccore.so.9+0x94d60) #2 vlc_player_track_Delete ../../src/player/track.c:153 (libvlccore.so.9+0x94d7d) #3 ctx_reset ../../test/src/player/player.c:630 (test_src_player+0x484d) #4 test_end ../../test/src/player/player.c:1044 (test_src_player+0x5696) #5 test_es_selection_override ../../test/src/player/player.c:2913 (test_src_player+0x5b18) #6 main ../../test/src/player/player.c:2960 (test_src_player+0xa9f2)
-
Lock fmt on read/write since it's written from the DecoderThread and read anywhere (when creating a meter module from the player).
-
-
- Apr 08, 2022
-
-
-
Steve Lhomme authored
APEv1 should have flags set to 0 (no footer), but let's not assume writers set this properly. https://mutagen-specs.readthedocs.io/en/latest/apev2/apev2.html
-
Steve Lhomme authored
The extra 32 octets are only needed if a certain flag is set. The size constraint is on the max amount that GetDWLE can return which doesn't have any limit in the specs: https://mutagen-specs.readthedocs.io/en/latest/apev2/apev2.html A different check on the size we actually allow to keep (MAX_TAG_SIZE) in memory is done elsewhere and doesn't belong in the header size reporter.
-
Steve Lhomme authored
vlc_stream_Read() cannot return properly more than that.
-
Steve Lhomme authored
- Apr 07, 2022
-
-
It requires the free AV1 extension to be installed. https://www.microsoft.com/en-us/p/av1-video-extension/9mvzqvxjbq9v
-
Modern DXVA decoders are not tied to a single Texture with all slices. We have to allocate the Shader Resource View (SRV) each time.
-
-
Due to a quirk in the ASS format some tags do depend on the exact storage size of the video not just the pixel aspect ratio, so tell libass via ass_set_storage_size to achieve correct rendering. For ASS, storage size refers to the size the video is encoded in (stored at) with codec-level crop applied; further transforms like e.g. anamorphic de-squeezing or container-level crop must not be applied. This matches the used fmt_src values despite them being named visible_{width,height} and the existing PAR calculation already relies on this. Fixes videolan/vlc#26634
-
delegate History update to the parent, instead of directly handling it in PageLoader.
-
The encoder is now fully deallocated by `vlc_encoder_Destroy` below.
-
Prefer clearing object resources instead of calling `module_unneed` which isn't set in all cases.
-
Leftover from b92f4f50
-
Regression from 5e633503 No consequences since p_aout is used to check the validity of the stream.
-
-
-
-
-
-
-
It is currently not implemented.
-
- Apr 06, 2022
-
-
Fix a leak happening when an input slave fails to load. Leak detected with asan: ``` Direct leak of 120 byte(s) in 1 object(s) allocated from: #0 0x7f56cb985ad7 in calloc (/lib64/libasan.so.6) #1 0x7f56cad22849 in InputSourceNew src/input/input.c:2605 #2 0x7f56cad2c9ca in input_SlaveSourceAdd src/input/input.c:3408 #3 0x7f56cad0f838 in LoadSlaves src/input/input.c:1164 #4 0x7f56cad1219a in Init src/input/input.c:1360 #5 0x7f56cad06092 in Run src/input/input.c:466 #6 0x7f56c9998b19 in start_thread (/lib64/libc.so.6) ```
-
-
Thomas Guillem authored
Not used by any modules, and not thread-safe.
-
Thomas Guillem authored
To avoid forward declarations (in the next commit).
-
Report that the stream is drained if play was never called or in case of overflow.
-
vlc_pa_get_latency() might return an invalid tick ("no timing info") when the stream was just uncorked from the Drain callback. To fix this issue, setup the drain timer from the latency callback when the stream is draining.
-
-
To avoid forward declaration in a future commit.
-
TimeGet() check the corked state, but the stream is always uncorked here.
-
The call is available since libsrt 1.3.0 which is the minimum we allow in configure.
-
-
-
-