Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The TransformMatrix is provided by Android to apply its internal
coordinates transformations to sample the texture at the correct
location, so it must be applied last, after the orientation/crop from
the picture_t.

The fact that their internal transform is exposed as an explicit matrix
is an arbitrary design choice from Android. Instead they could have
exposed a GLSL function "android_texture2D(vec2 coords)":

    vec2 tex_coords = TexCoordsMap * OrientationMatrix * pic_coords;
    vec4 texel = android_texture2D(tex_coords);

In that case, it is obvious that their transform would be applied last.

Refs <https://developer.android.com/reference/android/graphics/SurfaceTexture#getTransformMatrix(float%5B%5D)>

Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The transform matrix provided by Android is 4x4:
<https://developer.android.com/reference/android/graphics/SurfaceTexture#getTransformMatrix(float%5B%5D)>

However, the third column is never used, since the input vector is in
the form (s, t, 0, 1). Similarly, the third row is never used either,
since only the two first coordinates of the output vector are kept.

Using a 3x3 matrix simplifies the product with other 3x3 matrices.

Note: in theory, a 3x2 matrix would be sufficient, but use a square
matrix for wider compatibility with all OpenGL versions.

Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The orientation matrix applies a 2D affine transform, so a 3x3 matrix is
sufficient.

Fatih Uzunoğlu authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Extending spacer widget is not compatible with the central alignment,
so it makes sense to hide while this widget is being dragged

Fatih Uzunoğlu authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

toolbar widgets can not be expanded if placed in player toolbar center
alignment. However, this behavior was not being reflected in the toolbar
editor.

Fatih Uzunoğlu authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

completely fixes #25576

Fatih Uzunoğlu authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

fixes #25644.