Marvin Scholz authored 3 years ago and David committed 3 years ago

The Frameworks folder was missing in the rpath, leading to Frameworks
like Sparkle requiring change of the install_name after it was built
instead of just using rpath properly.

KO Myung-Hun authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Move the breakpad initialization right to the start of the program
and do not initialize breakpad if the VLC_DISABLE_BREAKPAD env variable
is set.

If breakpad is not used, the crash_handling variable is not used too,
but as it's used otherwise this should be silenced.

This gets rid of a prefix inside our build dir, and uses DESTDIR
when installing the content. This way, the install directory
can be reused for further packaging introduced in the next commits.

We were already using FromWide on this variable. It cannot work if TCHAR is
not wide.

This enables us to just run the vlc executable from an installed
directory like on any other POSIX installation. All modules should
work, apart the macOS interface module which requires the bundle
structure.

For posix-style installations, use the defined directories
for libraries and data.

With that, running vlc from the install dirs works fine in principle.
What is left to do currently is to adapt the RPATH to find the
libvlc libraries.

This is the correct place for bundling shared libraries (even if
they are not in the Framework structure).

This prevents these executables from linking to a shared
libssp-0.dll if both a static and shared version is available
of this library.

Since these refer to the dynamically linked libvlc via libvlc.la,
it will still pick up the correct shared version of those, instead
of refusing to link to a dynamic library (as it does for any
library specified via -l<name>).

The same use of -Wc,-static is present in a few other Makefile.am
already.

POSIX threads are always enabled implicitly.

Analog to 20bd2ef0.

KO Myung-Hun authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Marvin Scholz authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Rather than failing and existing silently.

Later patch wants to use argv[0].

pkglibexecdir is the pseudo-directory for internal executables.
vlc-qt-check already uses that. Indeed, PROGRAMS and SCRIPTS targets
are not allowed by automake in pkglibdir.

(libexecdir can be set to '${libdir}' in configure if/when the
distinction is unwanted.)

...when running in build tree.

Reported-by: Alexandre Fernandez <nerf@boboop.fr>

This looks like cargo cult. The function exists since XP SP1.