At this point, the two sets of helpers did essentially the same thing.
The only difference was that REMOVE_ELEM systematically shrinks the
table allocation, while TAB_ERASE waits for the table to become empty.

The cast, which is from the original stream output chain mega-patch,
assumed that all pointer types have same representation - which is
usually true. But it also assumed that tables would only contain
pointers; this might have been true back then, but it no longer is.

Filip Roséen authored 8 years ago and Rémi Denis-Courmont committed 8 years ago

These functions are no longer necessary nor used; future
implementations shall use vlc_array_init and vlc_array_clear
respectively).

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Filip Roséen authored 8 years ago and Rémi Denis-Courmont committed 8 years ago

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Fix missing error case

Fix missing error case

It should have been removed in the previous commit

This is a fixup of 48a64287. Also destroy the mpg123_handle with mpg123_delete()
when flushing.

(see also vorbisenc)

This is no longer used, and 100% of earlier uses were buggy.

The build do not seem to work and the package is never enabled.

Fix error handling. Piping in Makefile is usually a bad idea.

Fix error handling. Piping in Makefile is usually a bad idea.

Fix error handling. Piping in Makefile is usually a bad idea.

$(MOVE) must be the last command in the extract rule (if there is one).

$(MOVE) must be the last command in the extract rule (if there is one).

This ensures each new version will trigger a refetch.

This ensures each new version will trigger a refetch.

Fix #18034

Filip Roséen authored 8 years ago and Jean-Baptiste Kempf committed 8 years ago

For starters it is ill-formed to have zero-sized arrays according to the
ISO C++ Standard, but most importantly the code is unnecessary complex
since there is no need for the array at all (given that the elements
inside of it has been commented out).

This commit also changes a comment which has not been accurate for a
long time, though it would be possible to simplify the code in question
-- it is hard to prove that the behavior will not change, and as such it
has been left as is.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>