Pierre Lamot authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

also perform x11 resize when the makeCurrent fails

Co-authored-by: Jeffrey Knockel <jeff@jeffreyknockel.com>

Pierre Lamot authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

also perform x11 resize when the makeCurrent fails

Co-authored-by: Jeffrey Knockel <jeff@jeffreyknockel.com>

Pierre Lamot authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

QML will have an OpenGL context enabled, and the vout display may mess with it
while resizing

fix regression from d0836b10

Claudio Cambra authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Claudio Cambra authored 2 years ago and Marvin Scholz committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Benjamin Arnaud authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

fix #26670

Co-authored-by: Pierre Lamot <pierre@videolabs.io>

Benjamin Arnaud authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

fix #25598

Benjamin Arnaud authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

QImage::scaled provides a better quality compared to QImageReader::setScaledSize.
Except for svg(s).

This implementation that was removed in a prior commit should stay relevant in the future.

Pierre Lamot authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

when the player uses the fullscreen mode, the video should take the whole screen
space, using pined controls in this mode limits the available space for the video
to be displayed. We fallback to the non-pined mode in this case.

Alexandre Janniaux authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

The function is actually taking a vlc_config_subcat both from its
definition and its usage, which was creating warnings:

    modules/gui/macosx/preferences/prefs.m:533:82: warning: implicit conversion from enumeration type 'enum vlc_config_subcat' to different enumeration type 'enum vlc_config_cat' [-Wenum-conversion]
                        subcategoryItem = [categoryItem childRepresentingSubcategory:subcat];
                                          ~                                          ^~~~~~
    modules/gui/macosx/preferences/prefs.m:675:77: warning: conflicting parameter types in implementation of 'childRepresentingSubcategory:': 'enum vlc_config_cat' vs 'enum vlc_config_subcat' [-Wmismatched-parameter-types]
    - (VLCTreeBranchItem *)childRepresentingSubcategory:(enum vlc_config_subcat)subcategory
                                                         ~~~~~~~~~~~~~~~~~~~~~~ ^
    modules/gui/macosx/preferences/prefs.m:128:74: note: previous definition is here
    - (VLCTreeBranchItem *)childRepresentingSubcategory:(enum vlc_config_cat)category;
                                                         ~~~~~~~~~~~~~~~~~~~ ^

Pierre Lamot authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

this seems to happen in some case where graphical effects are used (drop shadow
on the audio cover in the full player for instance)

ref #26990

ref #26990

Sean McGovern authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

They became unreferenced in the move to v0.1.2 in 40148113.

As discussed on vlc-devel a few years back, it is desirable, if not
sometimes necessary, for media objects to be independent from any given
instance.

A typical reason would be to preparse media in one instance but play
them in another.

The caller ought to be able to select which instance the player should
be instantiated from.

Alexandre Janniaux authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

Unused after 8036a0f6.

Rémi Denis-Courmont authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

The caller may want to use a different instance than that which the
media was created from.

Prince Gupta authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

adapt qquickimageresponse to generate round image directly instead of
doing it as a separate task

this saves extra qobject allocation and main loop interruptions

Rémi Denis-Courmont authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

VLC requires a library version with custom source/destination memory
addresses. Note that we cannot look for symbols as some versions define
them as preprocessor macros aliasing other symbols.

Fixes #27068.

This can now be determined unambiguously from the parsed status.

Note that this shifts all the values by one, but binary compatibility is
already broken anyway.