Skip to content
Snippets Groups Projects

Implement Compact Overlay (PiP) for Issue #180

Merged Evan Blackstone requested to merge AgentCooper/vlc-winrt:feature/compact-overlay into master

Initial shot at implementing Compact Overlay based partially on Tim's earlier work. Adds a setting for using native Windows 10 pip instead of existing pip implementation. It should only appear on version of Windows 10 supporting compact overlay, and will be set to "on" by default on supported platforms.

Testing thus far has been performed on W10 1709 and Xbox One (to confirm the setting isn't visible).

Edited by Martin Finkel

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
10 12 {
11 13 public override void Execute(object parameter)
12 14 {
13 Locator.NavigationService.Go(Locator.SettingsVM.HomePage);
14 App.RootPage.StartCompositionAnimationOnSwapChain(true);
15 if (Locator.SettingsVM.CompactOverlayPiP && Locator.VideoPlayerVm.IsCompactOverlaySupported)
16 {
17 if (ApplicationView.GetForCurrentView().ViewMode == ApplicationViewMode.Default)
18 {
19 ApplicationView.GetForCurrentView().TryEnterViewModeAsync(ApplicationViewMode.CompactOverlay);
  • 10 12 {
    11 13 public override void Execute(object parameter)
    12 14 {
    13 Locator.NavigationService.Go(Locator.SettingsVM.HomePage);
    14 App.RootPage.StartCompositionAnimationOnSwapChain(true);
    15 if (Locator.SettingsVM.CompactOverlayPiP && Locator.VideoPlayerVm.IsCompactOverlaySupported)
    16 {
    17 if (ApplicationView.GetForCurrentView().ViewMode == ApplicationViewMode.Default)
    18 {
    19 ApplicationView.GetForCurrentView().TryEnterViewModeAsync(ApplicationViewMode.CompactOverlay);
    20 Locator.VideoPlayerVm.RequestChangeControlBarVisibility(false);
    21 }
    22
    23 if (ApplicationView.GetForCurrentView().ViewMode == ApplicationViewMode.CompactOverlay)
    24 {
    25 ApplicationView.GetForCurrentView().TryEnterViewModeAsync(ApplicationViewMode.Default);
  • 113 113 v.ExitFullScreenMode();
    114 114 }
    115 115
    116 public static void LeaveCompactOverlay()
    117 {
    118 if (ApiInformation.IsEnumNamedValuePresent("Windows.UI.ViewManagement.ApplicationViewMode", "CompactOverlay"))
    119 {
    120 if (ApplicationView.GetForCurrentView().ViewMode == ApplicationViewMode.CompactOverlay)
    121 {
    122 ApplicationView.GetForCurrentView().TryEnterViewModeAsync(ApplicationViewMode.Default);
  • added 1 commit

    • 0233d9e3 - Add setting for compact overlay. Modify InitPipCommand to implement it when appropriate.

    Compare with previous version

  • added 1 commit

    • 3e87575b - Add missing awaits to async functions in InitPipCommand and AppViewHelper.

    Compare with previous version

  • Evan Blackstone added 8 commits

    added 8 commits

    • 3e87575b...eb8e8e3b - 6 commits from branch videolan:master
    • 7b6f7126 - Add setting for compact overlay. Modify InitPipCommand to implement it when appropriate.
    • a7852915 - Add missing awaits to async functions in InitPipCommand and AppViewHelper.

    Compare with previous version

  • added 1 commit

    • d48e5118 - Add setting for compact overlay. Modify InitPipCommand to implement it when appropriate.

    Compare with previous version

  • added 1 commit

    • 5651ba33 - Fix InitPipCommand failure when VLC not maximized by adding returns after…

    Compare with previous version

  • added 1 commit

    • 1ea60b82 - Add setting for compact overlay. Modify InitPipCommand to implement it when appropriate.

    Compare with previous version

  • Martin Finkel unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Martin Finkel changed the description

    changed the description

  • Martin Finkel mentioned in commit 2dd19ba1

    mentioned in commit 2dd19ba1

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading