Ability to play external subs and audio

Currently, when watching a video through the video player, the app can only detect subtitles containing the video file's name. (e.g. Bao.mp4 and Bao.srt or Bao1.srt)

This feature allows the user to select any subtitles from the Files application in iOS and add them as a permanent subtitle for that video file. It is compatible with both local files and remote files through servers.

Current Issue: Adding subtitle for a remote file currently works when the application is still active, even when the video player is closed, but do not last more than one lifecycle (when the application is closed and then re-opened, the subtitle is gone from the tableView).

LocalFile1

FilePersistence

Close #391 (closed) and #1033 (closed)

Looks good so far! Remarks inline.

added 1 commit

• 5fb06dad - VLCPlaybackService: Added Localized Text for Select Subtitles From Files

Compare with previous version

added 1 commit

• a336c233 - VideoPlayerViewController: Added feature for adding external subtitle for local and remote videos

Compare with previous version

added Player label

changed milestone to %3.5.0

resolved all threads

resolved all threads

added 1 commit

• 150ee0c1 - VideoPlayerViewController: Added feature for adding external subtitle for local and remote videos

Compare with previous version

resolved all threads

added 2 commits

• db6d503b - still not working
• e156f158 - VideoPlayerViewController: Added if statement to check whether if a file is remote

Compare with previous version

there are several logic errors in your code. Please see this patch for a fix: 0001-logic-fixes.patch

added 1 commit

• d2d2ec88 - VideoPlayerViewController: Added feature for adding external subtitle for local and remote videos

Compare with previous version

added 1 commit

• 80bd8c16 - VideoPlayerViewController: add Audio Support

Compare with previous version

changed title from Draft: Ability to play external subs to Draft: Ability to play external subs and audio

changed the description