(cherry picked from commit 49941722)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 3f2623ae)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 4e76fa50)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit a54768fb)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 82b0fbe5)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit e85c9a90)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit df36f66f)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit e69c88ef)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Sort of cherry-picked from f379a95a

All read operations are already retried in case of spurious failure

(cherry picked from commit e29361c7)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

The album artist track count wasn't properly maintained

(cherry picked from commit c80a6356)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

fix #94

(cherry picked from commit 9ac9202b)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

refs #89

(cherry picked from commit 342b3bd2)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 48e6e92c)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Mention which version were affected, and that it shouldn't happen now.
Fix #89

(cherry picked from commit 72bcb0a5)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 7c93171f)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 6928d54f)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

As VLC desktop now requires it, and should there be unsupported features
on some various platforms, we already have some compat wrappers.
This is mostly for make_unique, init-capture, cbegin/cend, so minor
languages improvements.

(cherry picked from commit a5a8b34a)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

refs #92

(cherry picked from commit 8de4c09f)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 7661a1de)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

fix #92

(cherry picked from commit ae6cc2c1)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

We now ensure that we have a valid file when a fileId is stored, and we
ensured that a task has either an mrl or a fileId

(cherry picked from commit 19195148)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Provided the file has been created

(cherry picked from commit e0ba241f)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

We used to create task for external files (ie. m_parentFolderId == 0)
but this was fixed shortly after we bumped to model 12.
TL;DR: Even if we're migrating from model 11 or below, we can't have a
null parentFolderId anymore

(cherry picked from commit bdd57b52)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

The mrl wasn't assigned back to the corresponding variable, and was used
immediatly after.
This code leverages the "new" DeviceRemovedException which didn't exist
when this code was introduced. This also fixes an unlikely TOCTOU race

(cherry picked from commit 55792999)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 02006376)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 034c51c6)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Stop shipping artifacts for all builds, simply build & run tests
sequentially
Now also run coverage for each commits on master

(cherry picked from commit abdd81ea)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Delegate the discovererWorker checks to the test implementation, which
is the only one allowed not to have a discoverer set
fix #78

(cherry picked from commit 77ddd240)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Without the error message or a local reproduction, this can't really be
fixed, so apply a work around for the vlc-android 3.1.0 release

(cherry picked from commit 673e3142)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 76760df6)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 3d763660)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit f6c53934)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 481bd42c)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

When a folde represent a mountpoint, we can't generate its name upon
insertion, as the mountpoint path is only known at runtime.
Fix #72

(cherry picked from commit 77f558f2)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Or rather that concurrent thumbnail request won't cause the 2nd thread
to call std::terminate

(cherry picked from commit 690cdb97)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 0488ed41)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 1f931dc8)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Fix #69

(cherry picked from commit 4ddc95c2)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>