Makes this actually check the relevant requirements.

This is an insane case to work around, because no GPU backend enables
emulated format without the corresponding buffer support. I'd rather
pl_assert() it than return it as an error to the caller.

(Note that we already hit the slice_w assertion in this case)

OpenGL has emulated texture formats that don't need texel storage buffer
emulation, so support this case also.

Note that this change does not actually do anything yet, but I plan on
re-using this helper in the (near) future.

We only need to use the max SSBO sizee for emulated transfers.
Otherwise, max_buf_size is sufficient.

This helper was failing to account for the pixel stride alignment
requirements.

This accidentally sharpened the frame mixer when the source fps was
below monitor fps.

This will inflate all numbers, but is also more informative.

By one that doesn't have such strict requirements on the texture size.

Unceremoniously stolen from multigpu-bench.

Turn these defines into enums and group them more appropriately, and
make the queue configuration configurable (for testing).

Instead of linearly desaturating, use a third-order polynomial
approximation.

Re-use an existing helper and remove a misleading comment.

We can early-dispatch this callback as soon as we're done mempcying the
data into a temporary buffer.

Fixes: https://github.com/mpv-player/mpv/issues/12512

Kacper Michajłow authored 1 year ago and Niklas Haas committed 1 year ago

Fixes: https://github.com/haasn/libplacebo/issues/207

Fortunately, the existence of fast scalers masked this bug to some
extent, except in mpv, where the fast gaussian shader was not yet mapped.

Fixes: 364612f7
Fixes: https://github.com/haasn/libplacebo/issues/209

`pt` is already a vec2.

Regression caused by the #pragma GLSL rewrite, where
sh_const_float/SH_FLOAT was unintentionally replaced by ${const float},
despite this being the equivalent of a hard-coded float (%f).

Take care of some minor cosmetic fixes while we're at it.

Fixes: 94722c55

This was accidentally inverted...

Fixes unnatural black flickering in some scenes where encoding noise
pushes the background between 0 and 1 PQ. Adding a 1% PQ cutoff allows
censoring such values to 0.

I could also have hard-coded this constant but I decided it's simple
enough to expose, and it being tunable may help with tracking down
related issues in the future, and also allows users to opt out of this
functionality altogether.

Fixes: https://yabb.jriver.com/interact/index.php/topic,136378.msg950343.html#msg950343

Will allow me to extend it with conditional branches more easily.

To allow tagging deprecated fields with the specific version that
deprecated them. The argument is technically just free-form text, so I
decided to put the major version and API version of the deprecation.
This gives users the most clarity, I think.

It will admittedly make rebasing commits that touch the API version
slightly more annoying, but hopefully this is manageable in practice.

Also be a bit more consistent about the placement of deprecation macros.

llyyr authored 1 year ago and Niklas Haas committed 1 year ago

This would break build because _XOPEN_SOURCE works differently on
FreeBSD than on Linux, so just remove it since it's not needed.

Can I have an AI proofread my code already?

This resulted in some confusion, with users possibly expecting
pl_options_reset(opts, NULL) to give them pl_render_default_params. This
is, however, not the case.

Not that this really matters given that we use our own PRNG instead of
the spec-defined one, but maybe somebody will try to replace the PRNG by
a reference implementation in the future?

See-Also: http://ffmpeg.org/pipermail/ffmpeg-devel/2023-September/314995.html

See-Also: http://ffmpeg.org/pipermail/ffmpeg-devel/2023-September/314994.html

For next release.

Prevent the options documentation from exploding in size.