Marvin Scholz authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

If no bin folder existed, it would install the dump_syms binary
to a binary called bin, causing all other contribs built after to
fail with a rather confusing error as they are of course unable to
install into an executable named bin instead of a folder.

Don't always include media utils functions that need linkage to VLCCORE.

Fixes #25777

Don't wait more than CR_MAX_GAP. The CR_MAX_GAP might be too big
(60 seconds). This algorithm, like the one in input_clock.c could be
improved by comparing stream and system date.

This a work around buggy demuxers or corrupted samples/streams. That is
the reason that the new log should draw attention to developers.

Reset main clocks before unselecting every ESes. This will speed up
audio and video output termination. Indeed, they won't wait for a
specific PTS conversion. This may also unblock outputs in case of a
corrupted sample with a PTS very far in the future.

François Cartegnie authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

ends up reading wrong sample size/time

refs #25784

Co-Authored-By: Jean-Baptiste Kempf <jb@videolan.org>

Ashutosh Verma authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Fix typos, grammar in README.md. Add links too.

the null entry should not be there. caught this with some work to be
submitted later.

these lists takes signed ints.

this was caught by some later work that caused a warning here.

unused since 8f45b1e5

such strings are supposed to be translated JIT for display by interfaces.
this mistake causes a secondary translation to occur at an earlier and
incorrect time - in execution of the plugin descriptor.

such strings are supposed to be translated JIT for display by interfaces.
this mistake causes a secondary translation to occur at an earlier and
incorrect time - in execution of the plugin descriptor.

this is to be used exclusively by the core. mistaken use in other
modules results in issues in help output, as just fixed for the mp4
module.

'cat hints' should only be used by the core (to define a set of
headings to break its large set of options up with, instead of the
option tree items).

incorrectly using a cat hint here instead of a section means that this
"hacks" sub-heading gets printed like a module heading, which is both
imperfect from a neatness point of view, but also and more importantly
potentially confusing.

cdda and vcd were the only users, both have now been switched to use
`set_help()`.

usage hint is the wrong thing to use, help text is the right thing;
this mistake is the cause of confusing help output due to the fact that
usage hints are printed exactly the same as a plugin/module heading.

Lyndon Brown authored 6 years ago and Jean-Baptiste Kempf committed 3 years ago

note that the line adding a category entry is because it's moved from above.

Alexandre Janniaux authored 4 years ago and Felix Paul Kühne committed 3 years ago

The libtool versionning is there to handle linkage compatibility during
runtime with older/more recent version of the libraries. On iOS and
tvOS, the dynamic libraries MUST be shipped in a framework. A framework
already provides its own way of handling versionning, and applications
cannot install global dynamic libraries (except maybe on jailbroken
devices) so cannot really use the libtool versionning features for
anything.

Alexandre Janniaux authored 4 years ago and Felix Paul Kühne committed 3 years ago

The libtool versionning is there to handle linkage compatibility during
runtime with older/more recent version of the libraries. On iOS and
tvOS, the dynamic libraries MUST be shipped in a framework. A framework
already provides its own way of handling versionning, and applications
cannot install global dynamic libraries (except maybe on jailbroken
devices) so cannot really use the libtool versionning features for
anything.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

VolumeSet (called from any threads) was accessing the au_unit variable,
that is written and setup from the aout stream thread.

This also fixes possible crashes when changing the volume after a
failing Start().

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Fix data race with au_unit. Indeed, the aout can be muted from any
threads.

SPDIF playback can now be muted.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Fix data race with au_init, leading to crashes, since the audiounit was
stopped from a different thread than the playback one. Indeed, mute
callback can be called from any threads.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

It can be used as a hint to whether the buffer needs to be processed or
not.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This will write 0s from the render callback without touching at the
playback buffer state.