- May 29, 2021
-
-
Lyndon Brown authoredthis is to be used exclusively by the core. mistaken use in other modules results in issues in help output, as just fixed for the mp4 module.
-
Lyndon Brown authored
'cat hints' should only be used by the core (to define a set of headings to break its large set of options up with, instead of the option tree items). incorrectly using a cat hint here instead of a section means that this "hacks" sub-heading gets printed like a module heading, which is both imperfect from a neatness point of view, but also and more importantly potentially confusing.
-
Lyndon Brown authored
cdda and vcd were the only users, both have now been switched to use `set_help()`.
-
Lyndon Brown authored
usage hint is the wrong thing to use, help text is the right thing; this mistake is the cause of confusing help output due to the fact that usage hints are printed exactly the same as a plugin/module heading.
-
-
-
-
note that the line adding a category entry is because it's moved from above.
-
-
- May 28, 2021
-
-
The libtool versionning is there to handle linkage compatibility during runtime with older/more recent version of the libraries. On iOS and tvOS, the dynamic libraries MUST be shipped in a framework. A framework already provides its own way of handling versionning, and applications cannot install global dynamic libraries (except maybe on jailbroken devices) so cannot really use the libtool versionning features for anything.
-
The libtool versionning is there to handle linkage compatibility during runtime with older/more recent version of the libraries. On iOS and tvOS, the dynamic libraries MUST be shipped in a framework. A framework already provides its own way of handling versionning, and applications cannot install global dynamic libraries (except maybe on jailbroken devices) so cannot really use the libtool versionning features for anything.
-
- May 27, 2021
-
-
VolumeSet (called from any threads) was accessing the au_unit variable, that is written and setup from the aout stream thread. This also fixes possible crashes when changing the volume after a failing Start().
-
-
Fix data race with au_unit. Indeed, the aout can be muted from any threads. SPDIF playback can now be muted.
-
Fix data race with au_init, leading to crashes, since the audiounit was stopped from a different thread than the playback one. Indeed, mute callback can be called from any threads.
-
It can be used as a hint to whether the buffer needs to be processed or not.
-
This will write 0s from the render callback without touching at the playback buffer state.
-
libvlc_MediaFreed was removed in ff8775c9
-
- May 25, 2021
-
-
FT_Glyph_Stroke is more tolerant of font files that do not follow contour orientation conventions, like Helvetica Neue. It also creates unfilled outline glyphs that can be more efficiently blended. Fixes #21043
-
Steve Lhomme authored
It is imprecise and on seek it may wait a lot of time as, while it's waiting, the decoder threads will flood new frames, delaying that much longer until the ID3D11DeviceContext is finished doing things. This workaround did more harm than good. Now that we have ID3D11Fence support (any recent Win10) the query based system should not be used. For older Windows using D3D11 we'll have less precise estimation of the time it took to actually render, meaning the frame drop will be less effective.
-
- May 24, 2021
-
-
-
closes #25588
-
- May 23, 2021
-
-
-
with an earlier commit in this set having added a tooltip using longtext to the first column of the hotkey editing table, allowing users to get an additional description to help them understand the purpose of an action, it would be great for best UX if we have such a tooltip for each and every entry in the table. of the 113 entries, 9 were missing longtext and thus missing the tooltip. it was for this reason i skipped hotkeys in d75459a3. the "Select the hotkey to use..." form was used with that being fairly common for hotkey longtext. i used a single common longtext for the four zoom presets, as done already with bookmarks and subtitle text scaling, reducing translator burden.
-
these are not for hotkey options they are for playlist options
-
move the clear playlist and subtitle scaling hotkey options above the bookmarks and jump-size ones. - in the hotkey widget they are surely more interesting than the big block of bookmark ones that otherwise come at the end. - in help output, since the bookmark ones and jump sizes ones each declare sections, these options appear miscategorised as being a part of the bookmark section. this was overlooked in 711733c6, or more likely perhaps lost from it in a rebase over time.
-
-
-
-
the parent is always the table.
-
we need 4 columns, not five. one element on the line with four was being pointlessly stretched across two.
-
now the above non-global check has been reduced to a single name check, we can strip the reverse of that here with an else. the one remaining condition is just to avoid work for empty mappings.
-
unlikely and better to add it rather than skip. being there with a blank label would better help diagnose what went wrong in testing, or if it slipped past testing, someone is more likely to notice and report the problem leading to a fix. note that we must conditionally use `qfut()` because the underlying translation function does not like nulls, and my fix for that was rejected.
-
we now rely upon checking option name rather than shorttext. it is somewhat less likely that a mistake with duplicate option names will have been made compared to duplicate shorttext, and duplicate option names presents an even bigger and broader problem that we currently do nothing about. this is not very useful towards helping with that, we'd want a full check of the entire table's option names if we cared to properly check things here.
-
this avoids doing a translation lookup of the displayed shorttext, and using the option name just feels more "correct". note that we strip the "global-" prefix with `+7` to get the match.
-
rather than getting a list of matching items, instead iterate over the list and compare, thus avoiding the allocations in building that list. this also puts us in a position to locate the row by option name rather than shorttext, which might be better.
-
the "Unset" text used to be used for all unset cases, but a long time ago all except this one got changed to use an empty string instead. having spent a bit of time trying to track down an answer in the git history as to the question of why, i gave up. i found no clear answer in the time spent looking. it very well may have been simply overlooked rather than deliberately left to create a clear distinction that a failure occurred. i'm going to assume that it was overlooked. i've thus changed it to return an empty string. i don't expect this to cause any problems for the two different uses in the Qt code.
-
-
the displayed text is always displayed translated for non-global, and this is the case for edits for global, but the initial unedited displayed text was not translated. due to the way the global data is temporarily stored in a `QMap`, it seems that the easiest way to fix this is to simply convert from `QString` to raw string pointer with `qtu()` and then back to `QString` with translation applied with `qfut()`.
-
-
