resolves warning about insecure function

resolves warning about insecure function

to avoid code duplication in cases where caller wants to possibly control
the directory chosen rather than just rely on default temporary directory.

to avoid messy and duplicated code creating temporary files.

and thus work properly cross platform

to prep for use of config_GetTempPath() and avoid duplicated logic.

param names changed to ones that make better sense for clarity.

on posix/linux the $TMPDIR path should be preferred, using "/tmp" as a
fallback. here we use our new config_GetTempPath() helper.

to provide a common interface to the system/user temporary directory.

we will make use of this with mkstemp().

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

missed in 63599c0a

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

missed in 488e0d6b

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Lyndon Brown authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Rename the picture chains to make it clearer who does what.

Use vlc_picture_chain_t for the local picture chains, not a full
picture_fifo_t which is supposed to have a lock.

In some rare case it's necessary to get a picture chain under lock and clear
it right after, without holding the lock while each item is being processed.

This requires picture_GetAndResetChain to return the same type.

Move the while at the start of the loop so it's easier to read what we loop on.

The local type is equivalent to vlc_picture_chain_t.

Each implementation uses the same double pointer.

Eventually it may be replaced by a vlc_list but that implies adding an extra
pointer in the picture_t structure.

Use the picture_chain API's and don't access the front picture directly.

In some rare case we may want to check the picture at the top of the chain/FIFO
without popping it.

Tanguy Dubroca authored 4 years ago and Alexandre Janniaux committed 4 years ago

Usage: ./vlc 'mock://<mock

 options>;video_orientation=<orientation>'

The video_orientation option is an integer representing the raw
values of video_orientation_t. Thus the range of possible values
is ORIENT_TOP_LEFT = 0 -> ORIENT_RIGHT_BOTTOM = 7.

Fix #25054

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>