Skip to content
Snippets Groups Projects
  1. Jan 18, 2022
    • Lyndon Brown's avatar
      core: move a few misorganised hotkey declarations · 9dc22033
      Lyndon Brown authored
      move the clear playlist and subtitle scaling hotkey options above
      the bookmarks and jump-size ones.
      
       - in the hotkey widget they are surely more interesting than the
         big block of bookmark ones that otherwise come at the end.
      
       - in help output, since the bookmark ones and jump sizes ones each
         declare sections, these options appear miscategorised as being a
         part of the bookmark section. this was overlooked in
         711733c6, or more likely perhaps
         lost from it in a rebase over time.
      
      (cherry-picked from 1cbb4d39).
      9dc22033
    • Lyndon Brown's avatar
      core: re-categorise the --demux-filter option · ff33402a
      Lyndon Brown authored
      move it from under the stream filter subcat to the demux subcat, which
      surely makes more sense.
      
      (cherry-picked from 8583743f).
      ff33402a
    • Lyndon Brown's avatar
      core: fix help output option categorization · 2bafcf6d
      Lyndon Brown authored
      (cherry-picked from 711733c6).
      
      cherry-picked with the following adjustments:
       - dropped the change to `CODEC_CAT_LONGTEXT` to avoid the string change.
       - "Input / Codecs" used instead of "Input access and codecs" to avoid
         introducing a new string.
      
      note that "Miscellaneous" is not a new string, it was just moved.
      
      note that the following strings newly used in this file all already exist
      with translation markers elsewhere in the codebase:
       - "Input"
       - "Input / Codecs"
       - "Advanced"
       - "Bookmarks"
       - "Interface"
      
      original commit log below:
      ---
      
      When core options are printed in terminal help output, category headings
      are only printed when a 'category hint' entry is encountered in the list.
      As things were, some hints were missing or otherwise misplaced, such that
      some options appeared mis-categorised. The preferences GUI interface is
      unaffected. This commit corrects the problem.
      
      The problem specifically consists of the following component issues:
      
       - When we get to INPUT category options, no hint is given. The input cat
         starts with a section called "track settings" and you can see that this
         gets printed immediately after the section "overlays" from the
         subpictures category; Thus it appears as though most input options are
         actually subpicture options.
      
       - Further down, the input sub-categories "vcodec" and "access" both have
         hints (of "decoders" and "input" respectively), resulting in headings
         being printed. But, for the latter, the title and longtext description
         actually reflects a heading that should apply to the entire input
         category. 'Decoders' as a heading for the VCodec sub-cat is wrong, and
         the longtext (CODEC_CAT_LONGTEXT) is worded to speak of one single
         option only.
      
       - Further still, you may find a "Performance options" section heading,
         but its location varies. It should appear under "Miscellaneous", but if
         there are no options to display under it (i.e. when not showing advanced
         options, and not on Windows), it thus appears instead under the
         "Playlist" category heading.
      
       - Next, when we get to the interface category, again no hint is given.
         The playlist category above it ends with the "services-discovery"
         option, but no title gets printed for the interface category, so it is
         directly followed by the interface options, starting with "verbose".
         Eventually we get a hint for the hotkeys interface sub-category and get
         a new heading.
      
       - Finally, we get a '-1' category, hiding some options from the GUI. This
         illogically includes options like --help along with bookmark and
         bookmark-hotkey options. Furthermore there is no hint, thus all of these
         are appearing under the "hotkeys" heading, specifically in fact the
         "Jump sizes" section.
      
      This commit addresses these issues by:
      
       - Moving the input category hint up to where that category actually starts.
      
       - Moving the SUBCAT_INPUT_VCODEC subcat block to a more logical position.
      
       - Changing the "Decoders" hint that starts the access/codec input options
         to "Input access and codecs" and rewriting the longtext.
      
       - Removing MISC_CAT_LONGTEXT which didn't make sense in context.
      
       - Changing the "Miscellaneous" hint for the advanced category to
         "Advanced" matching the category title in the (Qt) GUI.
      
       - Moving the "--bookmark1", "--bookmark2", etc block of options that
         relate to playlists up to the general playlist category, though retaining
         the -1 subcat to ensure that they are still correctly hidden in the GUI.
         (the individual options need hiding as they are separately found and
         included in the big hotkey table control).
      
       - Adding a hint for the interface category, so we get a heading now. (This
         re-used the already existing longtext).
      
       - Clarifying the comment (now duplicated) about hiding options with the -1
         cat/subcat hack, by mentioning this relates to the GUI.
      
       - Adding a "Bookmarks" section heading for bookmark hotkey options, to
         separate these from the previous "Jump Sizes" section.
      
       - Adding a "Miscellaneous" hint before the block at the end which includes
         the help output options to create a new heading, separating this stuff
         from the previous hotkeys (interface sub-cat) heading.
      
       - Moving the -1 cat/subcat that was incorrectly above the bookmark-hotkey
         options down to this misc block.
      
      Also, I've moved the module name up to the top (clearer IMO).
      2bafcf6d
  2. Jan 17, 2022
  3. Jan 15, 2022
  4. Jan 14, 2022
    • Felix Paul Kühne's avatar
      upnp: fix browsing of certain servers · 584bf4f6
      Felix Paul Kühne authored
      This is a partial revert of 785c6dfe. Some servers (notably PLEX, UMS,
      and some TV sets) amend the exposed media type with additional subtypes
      for further differentiation not relevant to VLC, so it is actually
      correct to compare the beginning of the string only.
      
      For instance "object.container" can turn into
      "object.container.storageFolder" or "object.container.person.musicArtist"
      so the plain strcmp will fail to recognize the container nature.
      
      Fixes vlc-ios#1239
      
      (cherry picked from commit 741f1f90)
      584bf4f6
  5. Jan 13, 2022
  6. Jan 12, 2022
  7. Jan 08, 2022
    • David's avatar
      bin: Add Frameworks directory to vlc-osx RPATH · 0b72ae60
      David authored and David's avatar David committed
      vlc-osx is used to generate the final VLC executable, and therefore
      the RPATH to the Frameworks directory is needed as well, in order
      to find the Sparkle framework.
      
      Followup fix for !1155.
      0b72ae60
  8. Jan 07, 2022
  9. Jan 04, 2022
  10. Jan 03, 2022
Loading