Skip to content
Snippets Groups Projects

lib: mediaplayer: fix API behavior regression

Merged Martin Finkel requested to merge mfkl/vlc:libvlc-mediaplayer-crashfix into master
All threads resolved!

In LibVLC 3, passing a NULL media to libvlc_media_player_set_media was explicitly supported.

In LibVLC 4, it currently crashes. This tiny change aims to re-align the behavior with liblvc 3.

Fixes vlc-unity#123 (closed)

Merge request reports

Merge request pipeline #155601 passed

Merge request pipeline passed for e74021fa

Merged by Hugo Beauzée-LuyssenHugo Beauzée-Luyssen 3 years ago (Nov 5, 2021 8:39am UTC)

Loading

Pipeline #155605 passed

Pipeline passed for e74021fa on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Martin Finkel added 1 commit

    added 1 commit

    • 43ec49c4 - review: preserve call to vlc_player_SetCurrentMedia when p_md is NULL

    Compare with previous version

  • Martin Finkel added 1 commit

    added 1 commit

    • 4ad07f62 - lib: mediaplayer: fix API behavior regression

    Compare with previous version

  • Thomas Guillem resolved all threads

    resolved all threads

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, have votes and score > 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

    This message was automatically generated by homer-bot.

  • added 10 commits

    Compare with previous version

  • Hugo Beauzée-Luyssen enabled an automatic merge when the pipeline for e74021fa succeeds

    enabled an automatic merge when the pipeline for e74021fa succeeds

  • mentioned in issue #24223 (closed)

  • Please register or sign in to reply
    Loading