Skip to content

vout: disable click-to-pause only for click-handling filters

Ayush Dey requested to merge deyayush6/vlc:click-filter into master

cf, discussion here #28952 (comment 470449)

A has_click_filter pointer flag has been introduced, which is set only for filters (logo, freeze, magnify, puzzle) that handle mouse click and release events. Hence, click-to-pause remains enabled for filters that handle mouse events but not click/release events (e.g., deinterlace, orient, etc.)

Further mouse event propagation is stopped when a video filter consumes the event (occurs for filters that handle click/release events).

Event-consuming behavior of click-handling filters:

  • puzzle: consumes until the puzzle is solved
  • magnify: consumes within the magnifying area
  • logo: consumes over the logo area
  • freeze: always consumes

Hence, propagation remains enabled for the rest of the filters, allowing other mouse events such as click-to-pause, dvdnav, etc.

Edited by Ayush Dey

Merge request reports

Loading