VLC4: click-to-pause doesn't work on interlaced videos

Steps to reproduce:

1. Download nightly VLC4 https://artifacts.videolan.org/vlc/nightly-win64-llvm/20250125-0443/vlc-4.0.0-dev-win64-9dc00813.7z
2. Set hardware-accelerated decoding to Disable
3. Restart VLC
4. Play McCartney-MPEG2_1080-interlaced_sample.mkv interlaced video from this forum post
5. Observe that click-to-pause doesn't work
6. Play any non-interlaced video
7. Observe that click-to-pause does work

changed the description

mentioned in merge request !6725

changed milestone to %4.0

It's a mkv issue instead ? Cc. @robUx4

This is due to 741cd4a6. And because of f30b631f any filtering is considered to have a mouse filter. However it doesn't does do it for all interlaced sources...

cc @deyayush6

This happens because of this callback that is only in the CPU deinterlacer: https://code.videolan.org/videolan/vlc/-/blob/ae69d42e44f979af075467a207eba97dff89d026/modules/video_filter/deinterlace/deinterlace.c#L462

mentioned in merge request !6739 (merged)

closed with merge request !6739 (merged)

closed with commit fbbd68f8

mentioned in merge request !6744 (closed)

Not closed as the issue exists with other filters handing mouse events but not clicks. And fbbd68f8 should be reverted anyway.

reopened

This it actually a blocking issue. If I open a DVD, it catches the mouse events and even handles clicks. The Qt GUI is hidden during playback, but it never gets any click again once the UI elements are not shown anymore. We cannot close the player.

You mean the issue in the DVD nav menu where the UI elements are not displayed upon mouse move?

No, in this case that's probably because the DVD handles the menu.

So, during DVD video playback (not the navigation menu), the UI elements do gets raised when I move the mouse. Is that the issue? I'm not sure I understand the issue correctly

When you start playing a DVD and the UI navigation disappears to just show the video, it's impossible to get the UI (qt layer) to do anything (the keyboard still works).

Does this patch fix this issue? It is from: !6725 (05486364)

I had a UI issue (Mouse not working on clickable subpicture elements) with interactive mkv and applying this fixed it.

 src/input/es_out.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/input/es_out.c b/src/input/es_out.c
index b2f48263bc..1dfd82b69b 100644
--- a/src/input/es_out.c
+++ b/src/input/es_out.c
@@ -3636,10 +3636,11 @@ static int EsOutVaControlLocked(es_out_sys_t *p_sys, input_source_t *source,
         p_es->mouse_event_cb = va_arg( args, vlc_mouse_event );
         p_es->mouse_event_userdata = va_arg( args, void * );
 
-        if( p_es->p_dec && p_es->mouse_event_cb )
+        if( p_es->p_dec )
             vlc_input_decoder_SetVoutMouseEvent( p_es->p_dec,
                 p_es->mouse_event_cb, p_es->mouse_event_userdata );
-        else /* fallback to player event */
+
+        if (! p_es->mouse_event_cb)
         {
             p_es->mouse_event_cb = MouseEventCb;
             p_es->mouse_event_userdata = p_es;
-- 

This seems to work. The pause on click works in regular videos, the menus work in DVDs, including in the Qt interface.

Nice!

You can do a merge request

Alright, just created it here: !6904 (merged)

added Component::Core Severity::blocker Type::bug labels

mentioned in merge request !6904 (merged)

closed with merge request !6904 (merged)