meson: add misc. defines in config.h to match autotools
Some extra code is used with these defines. They may be set individually on modules, but it should be done in autotools at the same time.
Merge request reports
Activity
changed milestone to %4.0
added Component::Build system: Meson label
cdata will define in the config.h regardless of whether the library is actually added as dependency or not. Are we really sure we want that, that seems really weird? @ePirat
This is also the case with autotools. All the
AC_DEFINE()
exist in theconfig.h
even if they are only set inside a test. For example you'll get this no matter what.I agree with @alexandre-janniaux that we should attempt for a clean as possible port, then again we already have things right now in config.h that probably shouldn't really be in there.
So I do not really have much opinion one way or another as I (or whoever else who feels like) should eventually go over the entries and get rid of the ones that are module specific and not needed in there…
So I do not really have much opinion one way or another as I (or whoever else who feels like) should eventually go over the entries and get rid of the ones that are module specific and not needed in there…
Note that this MR actually revert back to global config.h defines when it was dependency-local in the current version.
It does not revert any code. It does exactly what it says: "add misc. defines in config.h to match autotools". This what allowed me to see that some things we enabled in autotools but not in meson. That's the same reason I reordered the defines so that autotools and meson builds can be compared (as done in !6352 (merged)).
Once we have matching things on both sides we can start removing parts of in config.h that are not needed there. This is not a meson thing, it should be done on both sides. And after this MR they should not diverge regarding the usage of config.h.
added MRStatus::InReview label
added 10 commits
- 992e68a8 - meson: define HAVE_TIGER in config.h as in autotools
- ee08f5b8 - meson: define BSD VCD defines in config.h as in autotools
- f8287a48 - meson: define HAVE_POSTPROC_POSTPROCESS_H for legacy postprocess.h location
- 4ae987de - meson: reorder some defines to match the autotools config.h
- e8862203 - meson: enable code when libvorbis is found as in autotools
- c4de2c38 - meson: enable code when libplacebo is found as in autotools
- d2303237 - meson: enable code when zvbi is found as in autotools
- 426bdf75 - meson: enable code when telx is found as in autotools
- a51b261d - meson: add dvbcsa check
- c8d9fa4b - meson: add missing HAVE_CLOCK_xxx in config.h
Toggle commit listmentioned in merge request !6352 (merged)
added 163 commits
-
c8d9fa4b...d0f9cb8d - 151 commits from branch
videolan:master
- d0f9cb8d...a6264e4a - 2 earlier commits
- 58cf3238 - meson: define HAVE_TIGER in config.h as in autotools
- d411a670 - meson: define BSD VCD defines in config.h as in autotools
- c3e391d2 - meson: define HAVE_POSTPROC_POSTPROCESS_H for legacy postprocess.h location
- d50263ae - meson: reorder some defines to match the autotools config.h
- c2b6d2bc - meson: enable code when libvorbis is found as in autotools
- 49743a90 - meson: enable code when libplacebo is found as in autotools
- 211de0a6 - meson: enable code when zvbi is found as in autotools
- af1d16bc - meson: enable code when telx is found as in autotools
- d18c8143 - meson: add dvbcsa check
- 9ef131bf - meson: add missing HAVE_CLOCK_xxx in config.h
Toggle commit list-
c8d9fa4b...d0f9cb8d - 151 commits from branch
added MRStatus::NotCompliant label and removed MRStatus::InReview label
added MRStatus::InReview label and removed MRStatus::NotCompliant label
mentioned in merge request !6396 (merged)
added MRStatus::NotCompliant label and removed MRStatus::InReview label