Skip to content
Snippets Groups Projects

demux: mkv: separate Chapter Codec implementations

Merged Steve Lhomme requested to merge robUx4/vlc:codec-split into master
All threads resolved!

And move most UI/Button data in the dedicated thread. So it doesn't block the UI.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • NIT: Ultimately we should not use vlc_delete_all() and use propre reference counted objects.

    propre -> proper

  • Steve Lhomme added 19 commits

    added 19 commits

    • 05ece110...13547a65 - 9 earlier commits
    • bc3c6169 - demux: mkv: keep the mouse state of the track in the ESInfo
    • 103ee1f1 - demux: mkv: factorize the code to push an event
    • 5278bb8d - demux: mkv: don't keep the lock while processing keyboard/mouse events
    • b658f8a2 - demux: mkv: start the thread to handle UI events when we receive them
    • 58bc3f8c - demux: mkv: rename ResetPci to AbortThread
    • 7add98a4 - demux: mkv: send raw data packets to the Chapter Codec interpreters
    • f73518bd - demux: mkv: remove unused vlc_actions
    • 512d8ccf - demux: mkv: skip event if all tracks have been removed
    • d81f67e3 - demux: mkv: send the DVD button block to the interpreter via the event thread
    • 72d434c4 - demux: mkv: always call GetDVDInterpretor() under the lock_demuxer

    Compare with previous version

  • added MRStatus::InReview label and removed MRStatus::NotCompliant label

  • Steve Lhomme added 27 commits

    added 27 commits

    • 72d434c4...dc2a408f - 17 earlier commits
    • a608b4a1 - demux: mkv: remove unused vlc_actions
    • 01d926bd - demux: mkv: skip event if all tracks have been removed
    • 7d4ad24c - demux: mkv: send the DVD button block to the interpreter via the event thread
    • 97f8d622 - demux: mkv: always call GetDVDInterpretor() under the lock_demuxer
    • e0857e63 - demux: mkv: ckeck early for a valid ChapProcessTime
    • 41f6e775 - demuc: mkv: map the KaxChapterProcessData container only once
    • 02bb61ce - demux: mkv: let the container handle the element copy
    • b1564514 - demux: mkv: add missing helpers from libebml 2.0
    • 93ea000d - demux: mkv: use FindChild templates to look for ChapterCommand children
    • 3be40610 - demux: mkv: use a unique pointer for chapter codec data

    Compare with previous version

  • Steve Lhomme added 6 commits

    added 6 commits

    • 92f25f06 - demux: mkv: ckeck early for a valid ChapProcessTime
    • bbd99076 - demuc: mkv: map the KaxChapterProcessData container only once
    • 4898a339 - demux: mkv: let the container handle the element copy
    • 5737d4a0 - demux: mkv: add missing helpers from libebml 2.0
    • 8740562d - demux: mkv: use FindChild templates to look for ChapterCommand children
    • 528e8085 - demux: mkv: use a unique pointer for chapter codec data

    Compare with previous version

  • Denis Charmet resolved all threads

    resolved all threads

  • Steve Lhomme added 2 commits

    added 2 commits

    • 972b3807 - demux: mkv: use FindChild templates to look for ChapterCommand children
    • aa04e624 - demux: mkv: use a unique pointer for chapter codec data

    Compare with previous version

  • added MRStatus::Acceptable label and removed MRStatus::InReview label

  • added MRStatus::Accepted label and removed MRStatus::Acceptable label

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 34 commits

    added 34 commits

    • aa04e624...e7f161f4 - 6 commits from branch videolan:master
    • e7f161f4...a841fde9 - 18 earlier commits
    • f3077eb7 - demux: mkv: remove unused vlc_actions
    • 3cb1fd97 - demux: mkv: skip event if all tracks have been removed
    • a057468f - demux: mkv: send the DVD button block to the interpreter via the event thread
    • 8186c4a3 - demux: mkv: always call GetDVDInterpretor() under the lock_demuxer
    • bedd6b92 - demux: mkv: ckeck early for a valid ChapProcessTime
    • 9f96c1d2 - demuc: mkv: map the KaxChapterProcessData container only once
    • f6c5e3ec - demux: mkv: let the container handle the element copy
    • 42945dad - demux: mkv: add missing helpers from libebml 2.0
    • 1d286b22 - demux: mkv: use FindChild templates to look for ChapterCommand children
    • c6826ae2 - demux: mkv: use a unique pointer for chapter codec data

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when the pipeline for c6826ae2 succeeds

    enabled an automatic merge when the pipeline for c6826ae2 succeeds

  • merged

  • Please register or sign in to reply
    Loading