qt/qml: Removed property indexesFlat and Implemented QVariant

• qml: Safely removed property bool indexesFlat from DragItem.qml.
• qt: Implemented QVariant in the getData() method of MLBaseModel. Used QVariant in place of QVector and QModelIndexList, as the correct C++ method overload couldn't be picked by QML. (reference)

Fixes: FIXME, FIXME

@chub
Greetings from my side Pierre!
Hoping this message finds you well.

It would be a great help if you would review this MR of mine and suggest any required changes.

added MRStatus::NotCompliant label

added 2 commits

• 4f2ace63 - qml: Removed 'property bool indexesFlat' from DragItem.qml
• 3591674d - qt: Implemented QVariant in the 'getData()' method

Compare with previous version

added MRStatus::Reviewable label and removed MRStatus::NotCompliant label

added Component::Interface: Qt label

changed milestone to %4.0

The intention is good, but I think the approach is not correct. We should not remove types like that. QVariant should be only used when it is the only feasible approach.

I put the comment there:

    // FIXME: Qt does not pick the right method overload: (reinvestigate Qt 6)
    //        Ideally it should be named the same.

You should try to rename Q_INVOKABLE void getDataFlat(const QVector<int> &indexList, QJSValue callback); into Q_INVOKABLE void getData(const QVector<int> &indexList, QJSValue callback);. Hopefully Qt can pick the correct overload. Please let us know.

added MRStatus::InReview label and removed MRStatus::Reviewable label

mentioned in merge request !5267 (closed)

If Qt still does not pick the right overload in Qt 6, I think we can remove Q_INVOKABLE from these methods, add one that is invokable and takes QVariant as input and then forwards to the right method from that method.

added MRStatus::NotCompliant label and removed MRStatus::InReview label