vout: samplebufferdisplay: Fix leak caused by converter
CVPX converter wasn't deleted when display module was closed. These changes fix this issue and also apply small refactors to converter's related functions.
Merge request reports
Activity
assigned to @umxprime
added MRStatus::Reviewable label
- Resolved by Maxime Chapelet
added MRStatus::InReview label and removed MRStatus::Reviewable label
added 14 commits
-
8375bbe2...bc152ad9 - 10 commits from branch
videolan:master
- 07386d99 - vout: samplebufferdisplay: Rename converter functions
- 2d982af6 - vout: samplebufferdisplay: Move converter functions
- 9c428ae0 - vout: samplebufferdisplay: Delete converter when display closes
- 42ef0fd4 - vout: samplebufferdisplay: Allocate decoder device properly
Toggle commit list-
8375bbe2...bc152ad9 - 10 commits from branch
added MRStatus::Acceptable label and removed MRStatus::InReview label
mentioned in merge request !4372 (closed)
changed milestone to %4.0
added Component::Video: macOS / iOS / tvOS / visionOS label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 50 commits
-
42ef0fd4...07437f3b - 46 commits from branch
videolan:master
- e1821564 - vout: samplebufferdisplay: Rename converter functions
- 03a668f8 - vout: samplebufferdisplay: Move converter functions
- bf442dcb - vout: samplebufferdisplay: Delete converter when display closes
- f5116997 - vout: samplebufferdisplay: Allocate decoder device properly
Toggle commit list-
42ef0fd4...07437f3b - 46 commits from branch
enabled an automatic merge when the pipeline for f5116997 succeeds