Skip to content
Snippets Groups Projects

vout: samplebufferdisplay: Fix leak caused by converter

All threads resolved!

CVPX converter wasn't deleted when display module was closed. These changes fix this issue and also apply small refactors to converter's related functions.

Merge request reports

Merge request pipeline #394112 passed

Merge request pipeline passed for f5116997

Merged by Steve LhommeSteve Lhomme 1 year ago (Oct 11, 2023 9:07am UTC)

Merge details

  • Changes merged into with f5116997.
  • Deleted the source branch.

Pipeline #394116 passed

Pipeline passed for f5116997 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Guillem approved this merge request

    approved this merge request

  • Maxime Chapelet added 14 commits

    added 14 commits

    • 8375bbe2...bc152ad9 - 10 commits from branch videolan:master
    • 07386d99 - vout: samplebufferdisplay: Rename converter functions
    • 2d982af6 - vout: samplebufferdisplay: Move converter functions
    • 9c428ae0 - vout: samplebufferdisplay: Delete converter when display closes
    • 42ef0fd4 - vout: samplebufferdisplay: Allocate decoder device properly

    Compare with previous version

  • Maxime Chapelet resolved all threads

    resolved all threads

  • Steve Lhomme approved this merge request

    approved this merge request

  • Maxime Chapelet mentioned in merge request !4372 (closed)

    mentioned in merge request !4372 (closed)

  • Steve Lhomme changed milestone to %4.0

    changed milestone to %4.0

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 50 commits

    added 50 commits

    • 42ef0fd4...07437f3b - 46 commits from branch videolan:master
    • e1821564 - vout: samplebufferdisplay: Rename converter functions
    • 03a668f8 - vout: samplebufferdisplay: Move converter functions
    • bf442dcb - vout: samplebufferdisplay: Delete converter when display closes
    • f5116997 - vout: samplebufferdisplay: Allocate decoder device properly

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when the pipeline for f5116997 succeeds

    enabled an automatic merge when the pipeline for f5116997 succeeds

  • merged

  • Please register or sign in to reply
    Loading