Allow configuring mobile controller UI skip duration (fixes #26704)
Currently the seek buttons in the mobile web controller UI seek by a fixed 30 seconds. This is one of the buttons I'm referring to:
![](/-/project/435/uploads/ae6e9de7ecb0ead6164abde2c224c3bc/VLC_Mobile_Web_UI_with_back_skip_circled.png)
This merge request changes the buttons so that they jump by the "Short jump length" value configured in Interface > Hotkeys settings.
![](/-/project/435/uploads/c8bddb0332802b41f5451602c2fc2fdc/Screenshot_from_2023-04-13_23-18-43.png)
Fixes #26704 (closed)
Some notes
- I did this by exposing the short jump length value to the JavaScript in mobile.html. A different way I could have done this would be to add two new commands called e.g.
seek_backwards_short
andseek_forward_short
which would look up the configured duration and seek by it. I think the way I did it is more flexible for future changes, but happy to do it the other way if the maintainers disagree. - I chose to seek by the short jump length instead of e.g. the medium jump length because the short jump length is the "default" jump length that you get when you press the arrow keys without any modifiers. Note that since the default short jump length is 10 seconds, this will change the out-of-the-box behavior of the mobile controller UI.
- I wasn't sure if there were any backwards-compatibility considerations related to adding more fields to status.xml. I figured I'd open the MR and let y'all tell me if I need to fix anything.
Merge request reports
Activity
added 138 commits
-
226f240e...5478dc02 - 129 commits from branch
videolan:3.0.x
- eab0da79 - git apply libplacebo-5.patch
- 026b7221 - hardcode config
- aaa8cf32 - Seek based on hardcoded seek sec fields
- 4377533d - Do it in httprequest.lua
- 562a219c - Cool, it works
- 3690fa1b - Just have one global seek_sec variable
- 1ebd02c0 - Move
- f34e5866 - Revert "git apply libplacebo-5.patch"
- ca0251cf - re-comment
Toggle commit list-
226f240e...5478dc02 - 129 commits from branch
added MRStatus::Reviewable label
- Resolved by Steve Lhomme
You need to clean your git history before proposing a MR.
added MRStatus::InReview label and removed MRStatus::Reviewable label
changed milestone to %4.0
added Component::LUA scripts label
changed milestone to %3.0.x maintenance
- Resolved by Kerrick Staley
These fixes should go in the 4.0 branch first and then be backported to 3.0
added Component::Interface: HTTP server label
added 1 commit
- c32d4295 - Allow configuring mobile controller UI skip duration (fixes #26704 (closed))
mentioned in merge request !3539 (merged)
added MRStatus::NotCompliant label and removed MRStatus::InReview label
added MRStatus::InReview label and removed MRStatus::NotCompliant label
added 87 commits
-
f71a3633...4c99f1a4 - 86 commits from branch
videolan:master
- cdeb9c7c - Allow configuring mobile controller UI skip duration (fixes #26704 (closed))
-
f71a3633...4c99f1a4 - 86 commits from branch