taglib: wav: parse additional RIFF INFO tags
TagLib does not provide an union of both ID3v2 and INFO tags via the
usual File::tag()
method. Their justification lies in the code for
now:
/*!
* Returns the ID3v2 Tag for this file.
*
* \note This method does not return all the tags for this file for
* backward compatibility. Will be fixed in TagLib 2.0.
*/
ID3v2::Tag *tag() const;
To support WAV files providing RIFF INFO tags, we must specifically parse them before TagLib 2.0 (not released yet).
Fixes #25690 (closed)
Merge request reports
Activity
changed milestone to %4.0
added Component:: Metadata label
requested review from @jbk
- Resolved by Jean-Baptiste Kempf
Won't this silently break if TagLib gets updated? Is it correct to prioritise RIFF over ID3 (intuitively, I'd think the opposite).
added MRStatus::WaitingForReviewerFeedback label
- Resolved by Alaric Senat
added MRStatus::InReview label and removed MRStatus::WaitingForReviewerFeedback label
added MRStatus::Acceptable label and removed MRStatus::InReview label
@asenat please BP afterwards.
- Resolved by François Cartegnie
added MRStatus::InReview label and removed MRStatus::Acceptable label
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 27 commits
-
ab77247a...90e98b01 - 25 commits from branch
videolan:master
- 294cbdba - taglib: move default meta access to a function
- a26e2ba3 - taglib: wav: fix RIFF INFO tags parsing
-
ab77247a...90e98b01 - 25 commits from branch
enabled an automatic merge when the pipeline for a26e2ba3 succeeds
mentioned in issue #6587 (closed)