Skip to content
Snippets Groups Projects

taglib: wav: parse additional RIFF INFO tags

Merged Alaric Senat requested to merge asenat/vlc:taglib-parse-wav-info into master
All threads resolved!

TagLib does not provide an union of both ID3v2 and INFO tags via the usual File::tag() method. Their justification lies in the code for now:

/*!
 * Returns the ID3v2 Tag for this file.
 *
 * \note This method does not return all the tags for this file for
 * backward compatibility.  Will be fixed in TagLib 2.0.
 */
ID3v2::Tag *tag() const;

To support WAV files providing RIFF INFO tags, we must specifically parse them before TagLib 2.0 (not released yet).

Fixes #25690 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for this.

  • Jean-Baptiste Kempf approved this merge request

    approved this merge request

  • Alaric Senat added 1 commit

    added 1 commit

    • ab77247a - taglib: wav: fix RIFF INFO tags parsing

    Compare with previous version

  • Alaric Senat resolved all threads

    resolved all threads

  • @asenat please BP afterwards.

  • François Cartegnie
  • François Cartegnie resolved all threads

    resolved all threads

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 27 commits

    added 27 commits

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when the pipeline for a26e2ba3 succeeds

    enabled an automatic merge when the pipeline for a26e2ba3 succeeds

  • merged

  • mentioned in issue #6587 (closed)

  • Please register or sign in to reply
    Loading