Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,725
    • Issues 3,725
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 224
    • Merge requests 224
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !3162

transcode: disable pcr forwarding on error

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alaric Sénat requested to merge asenat/vlc:transcode-setpcr-disable into master Jan 25, 2023
  • Overview 2
  • Commits 4
  • Pipelines 2
  • Changes 5

This merge request introduce a new runtime error in the pcr_helper to replace an assert.

This assertion was too severe and deserve actual runtime handling.
The pcr_helper should just fail in case of inconsistent input/output. This can happen in various case such as bogus encoder or simply internal error in the pcr_helper code.
This patch is making sure the pcr_helper user can disable it in case of failure.

Refs #27730 (closed) !3138 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: transcode-setpcr-disable

VideoLAN code repository instance