macOS UI: Add placeholder image for the Music section

Fixes #27716 (closed)

Thanks

Thanks for your contribution!

When all of the following conditions are fulfilled, your MergeRequest will be reviewed by the Team:

• the check pipeline passes
• the MR is considered as 'mergeable' by gitlab

You can find more details about the acceptance process here.

This message was automatically generated by homer-bot.

added 302 commits

• e6673522...f18c7763 - 301 commits from branch videolan:master
• 547d8022 - macOS UI: Add placeholder image for the Music section

Compare with previous version

Please do not rebase your branch unless you make changes to the code or Gitlab tells you it needs to rebase. Now the branch you pushed is not in sync with the one in Gitlab. And you started 20 jobs in the CI for nothing.

changed milestone to %4.0

added Component::Interface: macOS label

added Platform::macOS label

Sorry Steve. I didn't knew about that. I will not do that with future merge requests

Should I create a new merge request??

@claucambra Do you know if we have a proper placeholder image for this in the design mockups?

Yeah, we should have a specific image on a per-music section basis (note icon in the songs, artist icon in the artists section etc.)

resolved all threads

added MRStatus::InReview label

There are a huge number of unrelated changes in the .XIB file, could you make sure to only include the changes relevant to the image @ujjwaltwitx? Thanks!

I wouldn't change the bezel type on the imagecell, we want a box around the icon being presented in the placeholder view

@claucambra I changed the border type to None and it fixed the issue. Originally it was set to "Bezel"

Please see the video library placeholder image for reference:

This is what the video library looks like with your changes:

And what the music library looks with your changes:

There are still breakages here, the bezel is a clear one but also the alignment of the placeholder image in the music library is off and the image and the text haven't changed. Seems this is not an issue in the XIB but somewhere else

Thanks @claucambra for the review. Will look into the issue and update you.

Just a general question, can anyone please suggest which code editor(vscode or something else) should I use. I am currently using vscode.

For work on the macOS gui Xcode is best

Thanks @claucambra.

Hello @claucambra. Can you share some resources so that I can get some idea on how to resolve this issue. I have been constantly surfing the internet for the past eight or more hours but have found nothing helpful.

added MRStatus::NotCompliant label and removed MRStatus::InReview label